From 13363782b255f44f2b65542fd302a614513fa794 Mon Sep 17 00:00:00 2001 From: Hauke Petersen Date: Mon, 13 Dec 2021 07:48:53 +0100 Subject: [PATCH 1/2] shell/sc_gnrc_udp: mark all feasible params const --- sys/shell/commands/sc_gnrc_udp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/shell/commands/sc_gnrc_udp.c b/sys/shell/commands/sc_gnrc_udp.c index 83b7a03f0f..6ee16a2e95 100644 --- a/sys/shell/commands/sc_gnrc_udp.c +++ b/sys/shell/commands/sc_gnrc_udp.c @@ -41,8 +41,8 @@ static gnrc_netreg_entry_t server = GNRC_NETREG_ENTRY_INIT_PID(GNRC_NETREG_DEMUX_CTX_ALL, KERNEL_PID_UNDEF); -static void send(char *addr_str, const char *port_str, const void *data, size_t num, - unsigned int delay) +static void send(const char *addr_str, const char *port_str, + const char *data, size_t num, unsigned int delay) { netif_t *netif; uint16_t port; @@ -113,7 +113,7 @@ static void send(char *addr_str, const char *port_str, const void *data, size_t } } -static void start_server(char *port_str) +static void start_server(const char *port_str) { uint16_t port; From bc0adc19a8d4eaf19c2d59f74d53725731fc1587 Mon Sep 17 00:00:00 2001 From: Hauke Petersen Date: Mon, 13 Dec 2021 07:50:43 +0100 Subject: [PATCH 2/2] shell/sc_gnrc_udp: rename static functions --- sys/shell/commands/sc_gnrc_udp.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sys/shell/commands/sc_gnrc_udp.c b/sys/shell/commands/sc_gnrc_udp.c index 6ee16a2e95..c2486c1d2b 100644 --- a/sys/shell/commands/sc_gnrc_udp.c +++ b/sys/shell/commands/sc_gnrc_udp.c @@ -41,8 +41,8 @@ static gnrc_netreg_entry_t server = GNRC_NETREG_ENTRY_INIT_PID(GNRC_NETREG_DEMUX_CTX_ALL, KERNEL_PID_UNDEF); -static void send(const char *addr_str, const char *port_str, - const char *data, size_t num, unsigned int delay) +static void _send(const char *addr_str, const char *port_str, + const char *data, size_t num, unsigned int delay) { netif_t *netif; uint16_t port; @@ -113,7 +113,7 @@ static void send(const char *addr_str, const char *port_str, } } -static void start_server(const char *port_str) +static void _start_server(const char *port_str) { uint16_t port; @@ -136,7 +136,7 @@ static void start_server(const char *port_str) printf("Success: started UDP server on port %" PRIu16 "\n", port); } -static void stop_server(void) +static void _stop_server(void) { /* check if server is running at all */ if (server.target.pid == KERNEL_PID_UNDEF) { @@ -175,7 +175,7 @@ int _gnrc_udp_cmd(int argc, char **argv) if (argc > 6) { delay = atoi(argv[6]); } - send(argv[2], argv[3], argv[4], num, delay); + _send(argv[2], argv[3], argv[4], num, delay); } else if (strcmp(argv[1], "server") == 0) { if (argc < 3) { @@ -187,10 +187,10 @@ int _gnrc_udp_cmd(int argc, char **argv) printf("usage %s server start \n", argv[0]); return 1; } - start_server(argv[3]); + _start_server(argv[3]); } else if (strcmp(argv[2], "stop") == 0) { - stop_server(); + _stop_server(); } else { puts("error: invalid command");