kaspar/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-25 14:33:52 +01:00
Code Releases Activity

cbor: compare asserted lengths in unit test

Browse Source 
In `test_array`, `test_array` and `test_map` the variable `offset` was
written to but not read. The accumulated value should equal the total
length of the input. This diff adds this check and fixes the warning
in turn.

Found via scan-build.
This commit is contained in:
René Kijewski 2015-08-24 23:56:23 +02:00
parent 79ac710ee5
commit 11ce199c41
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/unittests/tests-cbor/tests-cbor.c
View File

@ -351,6 +351,7 @@ static void test_array(void)
TEST_ASSERT_EQUAL_INT(1, i);
offset += cbor_deserialize_int(&stream, offset, &i);
TEST_ASSERT_EQUAL_INT(2, i);
TEST_ASSERT_EQUAL_INT(sizeof(data), offset);
}
cbor_clear(&stream);
@ -374,6 +375,7 @@ static void test_array(void)
char buffer[1024];
offset += cbor_deserialize_byte_string(&stream, offset, buffer, sizeof(buffer));
TEST_ASSERT_EQUAL_STRING("a", &(buffer[0]));
TEST_ASSERT_EQUAL_INT(sizeof(data), offset);
}
}
@ -442,6 +444,7 @@ static void test_map(void)
TEST_ASSERT_EQUAL_INT(2, key);
offset += cbor_deserialize_byte_string(&stream, offset, value, sizeof(value));
TEST_ASSERT_EQUAL_STRING("2", &(value[0]));
TEST_ASSERT_EQUAL_INT(sizeof(data), offset);
}
}