kaspar/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-25 22:43:50 +01:00
Code Releases Activity

make: Sort >/dev/null and 2>&1 when used with command

Browse Source 
This is a follow-up for [16775], and was not caught there as that search
was limited to `which`.

Note that while this line can be simplified, the redirects ensure that
GNU Make < 4.3 will not optimize it into its own built-in shell that
does not know `command`.

[16775]: https://github.com/RIOT-OS/RIOT/pull/16775
This commit is contained in:
chrysn 2021-09-03 13:24:39 +02:00
parent d94b4e0ec1
commit 25e11d99b1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dist/testbed-support/makefile.iotlab.single.inc.mk vendored
View File

@ -51,7 +51,7 @@ endif
IOTLAB_AUTH ?= $(HOME)/.iotlabrc
IOTLAB_USER ?= $(shell cut -f1 -d: $(IOTLAB_AUTH))
ifneq (0,$(shell command -v iotlab-experiment -h 2>&1 > /dev/null ; echo $$?))
ifneq (0,$(shell command -v iotlab-experiment -h > /dev/null 2>&1; echo $$?))
$(info $(COLOR_RED)'iotlab-experiment' command is not available \
please consider installing it from \
https://pypi.python.org/pypi/iotlabcli$(COLOR_RESET))
@ -60,7 +60,7 @@ endif
ifeq (iotlab-a8-m3,$(BOARD))
ifneq (,$(filter flash% reset,$(MAKECMDGOALS)))
ifneq (0,$(shell command -v iotlab-ssh -h 2>&1 > /dev/null ; echo $$?))
ifneq (0,$(shell command -v iotlab-ssh -h > /dev/null 2>&1; echo $$?))
$(info $(COLOR_RED)'iotlab-ssh' command is not available \
please consider installing it from \
https://pypi.python.org/pypi/iotlabsshcli$(COLOR_RESET))