From ee074e4464a4778a9e220d9ee83e71bcee507a3c Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 9 Aug 2022 10:37:29 +0200 Subject: [PATCH 01/15] .murdock: disable hash checks of kconfig/make Much CI time is waisted as unrelated hash failure occur. Finding out why is taking some time. In order to stop killing dolphins we will disable only the hash checks. There is a risk of introducing new issues with the kconfig/make dependency resolution. However, the package/module checks are still enforced which should catch 95% of the problems. The nightlies will continue to check as well. --- .murdock | 51 +++++++++++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/.murdock b/.murdock index a338e1e10c..8fa9030d73 100755 --- a/.murdock +++ b/.murdock @@ -456,15 +456,23 @@ compile() { if get_supported_kconfig_board_app "${board}" "${appdir}"; then should_check_kconfig_hash=1 - BOARD=${board} make -C${appdir} clean - CCACHE_BASEDIR="$(pwd)" BOARD=${board} TOOLCHAIN=${toolchain} RIOT_CI_BUILD=1 TEST_KCONFIG=1 \ - make -C${appdir} all test-input-hash -j${JOBS:-4} - RES=$? - if [ $RES -eq 0 ]; then - kconfig_hashes="$(cat ${BINDIR}/test-input-hash.sha1)" - else - kconfig_hashes="kconfig-build-failed" - echo "An error occurred while compiling using Kconfig"; + # As we have some issues with occasional unrelated hash mismatches + # we will stop the binary checks and rely only in a module/package + # check to ensure kconfig is matching make. + # Only nightlies will check the hash... + # Once we figure out the problem we can check the hashes again or + # better yet just finish! + if [ ${NIGHTLY} -eq 1 ]; then + BOARD=${board} make -C${appdir} clean + CCACHE_BASEDIR="$(pwd)" BOARD=${board} TOOLCHAIN=${toolchain} RIOT_CI_BUILD=1 TEST_KCONFIG=1 \ + make -C${appdir} all test-input-hash -j${JOBS:-4} + RES=$? + if [ $RES -eq 0 ]; then + kconfig_hashes="$(cat ${BINDIR}/test-input-hash.sha1)" + else + kconfig_hashes="kconfig-build-failed" + echo "An error occurred while compiling using Kconfig"; + fi fi fi @@ -474,22 +482,29 @@ compile() { make -C${appdir} all test-input-hash -j${JOBS:-4} RES=$? - no_kconfig_hashes="$(cat ${BINDIR}/test-input-hash.sha1)" + if [ ${NIGHTLY} -eq 1 ]; then + no_kconfig_hashes="$(cat ${BINDIR}/test-input-hash.sha1)" + fi # test hash is used to cache test results, not for comparing binaries # generated with and without KConfig test_hash=$(test_hash_calc "$BINDIR") if [ ${should_check_kconfig_hash} != 0 ]; then - if [ "${kconfig_hashes}" != "${no_kconfig_hashes}" ]; then - echo "Hashes of binaries with and without Kconfig mismatch for ${appdir} with ${board}"; - echo "Please check that all used modules are modelled in Kconfig and enabled"; - echo "Input without KConfig:" - echo "${no_kconfig_hashes}" - echo "Input with KConfig:" - echo "${kconfig_hashes}" + if [ ${NIGHTLY} -eq 1 ]; then + if [ "${kconfig_hashes}" != "${no_kconfig_hashes}" ]; then + echo "Hashes of binaries with and without Kconfig mismatch for ${appdir} with ${board}"; + echo "Please check that all used modules are modelled in Kconfig and enabled"; + echo "Input without KConfig:" + echo "${no_kconfig_hashes}" + echo "Input with KConfig:" + echo "${kconfig_hashes}" + kconfig_module_packages_diff ${board} ${appdir} + RES=1 + fi + else kconfig_module_packages_diff ${board} ${appdir} - RES=1 + RES=$(( $RES | $? )) fi fi From 606402e8481394a4244b8aa30e0c28b74f9f7bf9 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Thu, 11 Aug 2022 09:35:18 +0200 Subject: [PATCH 02/15] drivers: Only select periph_gpio_ll_irq_unmask if needed --- drivers/periph_common/Makefile.dep | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/periph_common/Makefile.dep b/drivers/periph_common/Makefile.dep index 714a674bd3..5a08a3c0e4 100644 --- a/drivers/periph_common/Makefile.dep +++ b/drivers/periph_common/Makefile.dep @@ -1,2 +1,4 @@ # Always use periph_gpio_irq_unmask, if available -FEATURES_OPTIONAL += periph_gpio_ll_irq_unmask +ifneq (,$(filter periph_gpio_ll%,$(USEMODULE))) + FEATURES_OPTIONAL += periph_gpio_ll_irq_unmask +endif From 01eebc700013e4f451f58e01143e8dacaedb1309 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Fri, 12 Aug 2022 10:28:58 +0200 Subject: [PATCH 03/15] Makefile.include: remove CI-build: skipping link step This creates diff failures when calling info-modules and info-packages. Ideally info-modules and info-packages have clean output for the CI build --- Makefile.include | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile.include b/Makefile.include index eb62097a50..d203281f84 100644 --- a/Makefile.include +++ b/Makefile.include @@ -484,11 +484,13 @@ endif # Check if programmer is supported by the board, only if PROGRAMMERS_SUPPORTED # is set and if programmer is not iotlab -ifneq (iotlab,$(PROGRAMMER)) - ifneq (,$(PROGRAMMERS_SUPPORTED)) - ifeq (,$(filter $(PROGRAMMER),$(PROGRAMMERS_SUPPORTED))) - $(info '$(PROGRAMMER)' programmer is not supported by this board. \ - Supported programmers: '$(PROGRAMMERS_SUPPORTED)') +ifneq ($(RIOT_CI_BUILD),1) + ifneq (iotlab,$(PROGRAMMER)) + ifneq (,$(PROGRAMMERS_SUPPORTED)) + ifeq (,$(filter $(PROGRAMMER),$(PROGRAMMERS_SUPPORTED))) + $(info '$(PROGRAMMER)' programmer is not supported by this board. \ + Supported programmers: '$(PROGRAMMERS_SUPPORTED)') + endif endif endif endif @@ -526,7 +528,6 @@ ifeq ($(RIOT_CI_BUILD),1) # set a dummy version number RIOT_VERSION_CODE ?= $(RIOT_VERSION_DUMMY_CODE) ifneq ($(filter $(BOARD_INSUFFICIENT_MEMORY), $(BOARD)),) - $(info CI-build: skipping link step) RIOTNOLINK:=1 endif # be more quiet when building for CI From 99f4fd633e70846fcfa3b9fbf0d4f7fe80956387 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Fri, 12 Aug 2022 10:40:16 +0200 Subject: [PATCH 04/15] makefiles: Prevent periph_init_mcg_lite module --- makefiles/features_modules.inc.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/makefiles/features_modules.inc.mk b/makefiles/features_modules.inc.mk index 84c8cdda96..86816ac725 100644 --- a/makefiles/features_modules.inc.mk +++ b/makefiles/features_modules.inc.mk @@ -26,6 +26,7 @@ PERIPH_IGNORE_MODULES := \ periph_i2c_sw \ periph_init% \ periph_mcg \ + periph_mcg_lite \ periph_plic \ periph_rtc_ms \ periph_rtc_rtt \ From 54c4bd56ca225a1a3b4952ac51e95c67343a2c94 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Fri, 12 Aug 2022 14:07:49 +0200 Subject: [PATCH 05/15] sys/cpp11-compat: Fix kconfig model --- sys/cpp11-compat/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/cpp11-compat/Kconfig b/sys/cpp11-compat/Kconfig index d1a9e55309..235a3a3ae6 100644 --- a/sys/cpp11-compat/Kconfig +++ b/sys/cpp11-compat/Kconfig @@ -11,7 +11,9 @@ config MODULE_CPP11-COMPAT depends on HAS_CPP depends on HAS_LIBSTDCPP + select MODULE_CPP + select MODULE_LIBSTDCPP select MODULE_CPP_NEW_DELETE select MODULE_XTIMER select MODULE_TIMEX From 40f4950f8521197744df90a2ad107e5f48d80d92 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 09:10:19 +0200 Subject: [PATCH 06/15] drivers/at24cxxx: Fix kconfig model --- boards/avr-rss2/Kconfig | 1 + boards/same54-xpro/Kconfig | 1 + drivers/at24cxxx/Kconfig | 1 - drivers/mtd/Kconfig | 2 -- 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/boards/avr-rss2/Kconfig b/boards/avr-rss2/Kconfig index 2923288f2d..0f282b886d 100644 --- a/boards/avr-rss2/Kconfig +++ b/boards/avr-rss2/Kconfig @@ -24,6 +24,7 @@ config BOARD_AVR_RSS2 select HAVE_SAUL_GPIO select HAVE_BME280_I2C select HAVE_AT24MAC + select HAVE_MTD_AT24CXXX source "$(RIOTBOARD)/common/atmega/Kconfig" diff --git a/boards/same54-xpro/Kconfig b/boards/same54-xpro/Kconfig index fcd1cabab3..06a9a1d64b 100644 --- a/boards/same54-xpro/Kconfig +++ b/boards/same54-xpro/Kconfig @@ -29,6 +29,7 @@ config BOARD_SAME54_XPRO select HAVE_AT24MAC select HAVE_SAM0_ETH select HAVE_SAM0_SDHC + select HAVE_MTD_AT24CXXX # This specific board requires SPI_ON_QSPI for the MTD_SPI_NOR select MODULE_PERIPH_SPI_ON_QSPI if MODULE_MTD_SPI_NOR diff --git a/drivers/at24cxxx/Kconfig b/drivers/at24cxxx/Kconfig index 9b62401da0..9a7479bd28 100644 --- a/drivers/at24cxxx/Kconfig +++ b/drivers/at24cxxx/Kconfig @@ -63,6 +63,5 @@ config MODULE_AT24CXXX bool depends on HAS_PERIPH_I2C depends on TEST_KCONFIG - select HAVE_MTD_AT24CXXX select MODULE_PERIPH_I2C select MODULE_XTIMER diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 4cd4689897..b12543d9be 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -7,14 +7,12 @@ config HAVE_MTD_AT24CXXX bool - depends on MODULE_AT24CXXX imply MODULE_MTD_AT24CXXX if MODULE_MTD help Indicates that a at24cxxx EEPROM MTD is present config HAVE_MTD_AT25XXX bool - depends on MODULE_AT25XXX imply MODULE_MTD_AT25XXX if MODULE_MTD help Indicates that a at25xxx SPI-EEPROM MTD is present From 3e7751ab62f2b8925c2a76ea1c3247184591c5a9 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 09:20:23 +0200 Subject: [PATCH 07/15] drivers/at25xxx: Fix kconfig model --- drivers/at25xxx/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/at25xxx/Kconfig b/drivers/at25xxx/Kconfig index bae51c68d0..008a973078 100644 --- a/drivers/at25xxx/Kconfig +++ b/drivers/at25xxx/Kconfig @@ -9,7 +9,6 @@ config MODULE_AT25XXX bool "AT25xxx SPI-EEPROMs" depends on HAS_PERIPH_SPI depends on TEST_KCONFIG - select HAVE_MTD_AT25XXX select MODULE_PERIPH_SPI select MODULE_XTIMER help From f79f43903d05af5610d969c68762fe44a13cd704 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 09:58:46 +0200 Subject: [PATCH 08/15] cpu/periph_eth: Fix kconfig model This probably can be done better as the periph_eth should not be only part of the stm32 as the sam0 also uses it. --- cpu/stm32/periph/Kconfig.eth | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpu/stm32/periph/Kconfig.eth b/cpu/stm32/periph/Kconfig.eth index 322725f31d..cbdfe85555 100644 --- a/cpu/stm32/periph/Kconfig.eth +++ b/cpu/stm32/periph/Kconfig.eth @@ -40,7 +40,7 @@ endif # MODULE_STM32_ETH config MODULE_PERIPH_ETH bool depends on HAS_PERIPH_ETH - select MODULE_PERIPH_ETH_COMMON + select MODULE_PERIPH_ETH_COMMON if CPU_STM32 config MODULE_PERIPH_ETH_COMMON bool From 93aa0e64142f165e98e3f471754f2ce5c5d432bb Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 09:59:26 +0200 Subject: [PATCH 09/15] tests/driver_dfplayer: fix app.config.test --- tests/driver_dfplayer/app.config.test | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/driver_dfplayer/app.config.test b/tests/driver_dfplayer/app.config.test index cb6a5817cb..413048393b 100644 --- a/tests/driver_dfplayer/app.config.test +++ b/tests/driver_dfplayer/app.config.test @@ -5,7 +5,6 @@ CONFIG_MODULE_DFPLAYER=y # enable event thread in lowest priority CONFIG_MODULE_EVENT=y CONFIG_MODULE_EVENT_THREAD=y -CONFIG_MODULE_EVENT_THREAD_LOWEST=y # enable shell with basic commands CONFIG_MODULE_SHELL=y From 418d1c7ba0c245a7ebed06a8deecaeb46b999da1 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 10:11:00 +0200 Subject: [PATCH 10/15] external_boards/esp32c3-ci: Add esp_jtag to test --- tests/external_board_dirs/esp-ci-boards/esp32c3-ci/Makefile.dep | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/external_board_dirs/esp-ci-boards/esp32c3-ci/Makefile.dep b/tests/external_board_dirs/esp-ci-boards/esp32c3-ci/Makefile.dep index 90029202a1..991cc25487 100644 --- a/tests/external_board_dirs/esp-ci-boards/esp32c3-ci/Makefile.dep +++ b/tests/external_board_dirs/esp-ci-boards/esp32c3-ci/Makefile.dep @@ -2,6 +2,7 @@ USEMODULE += board_esp32c3-ci USEMODULE += esp_idf_heap +USEMODULE += esp_jtag USEMODULE += esp_log_startup USEMODULE += esp_log_tagged From 9b6036def36664d892681242ba28a3ee5e73bfd2 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 10:28:37 +0200 Subject: [PATCH 11/15] cpu/efm32/periph: remove seriesn in kconfig As this is not handled in the makefile.dep it does not need to be modeled in kconfig. --- cpu/efm32/periph/Kconfig | 46 ---------------------------------------- 1 file changed, 46 deletions(-) diff --git a/cpu/efm32/periph/Kconfig b/cpu/efm32/periph/Kconfig index 5f8217d5fe..afb807b287 100644 --- a/cpu/efm32/periph/Kconfig +++ b/cpu/efm32/periph/Kconfig @@ -8,49 +8,3 @@ config MODULE_PERIPH bool default y - -if MODULE_PERIPH - -config MODULE_PERIPH_WDT_SERIES0 - bool - depends on CPU_EFM32_SERIES0 - default MODULE_PERIPH_WDT - help - WDT driver implementation for EFM32 series 0. - -config MODULE_PERIPH_WDT_SERIES1 - bool - depends on CPU_EFM32_SERIES1 - default MODULE_PERIPH_WDT - help - WDT driver implementation for EFM32 series 1. - -config MODULE_PERIPH_RTC_SERIES0 - bool - depends on CPU_EFM32_SERIES0 - default MODULE_PERIPH_RTC - help - RTC driver implementation for EFM32 series 0. - -config MODULE_PERIPH_RTC_SERIES1 - bool - depends on CPU_EFM32_SERIES1 - default MODULE_PERIPH_RTC - help - RTC driver implementation for EFM32 series 1. - -config PERIPH_RTT_SERIES0 - bool - depends on CPU_EFM32_SERIES0 - default MODULE_PERIPH_RTT - help - RTT driver implementation for EFM32 series 0. - -config PERIPH_RTT_SERIES1 - bool - depends on CPU_EFM32_SERIES1 - default MODULE_PERIPH_RTT - help - RTT driver implementation for EFM32 series 1. - -endif # MODULE_PERIPH From f7569b57e442be19b46acebb818afc0b1c00a923 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 10:56:23 +0200 Subject: [PATCH 12/15] tests/periph_rtc: Fix kconfig model --- tests/periph_rtc/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/periph_rtc/Kconfig b/tests/periph_rtc/Kconfig index aed0dbc6fe..28f35f69f8 100644 --- a/tests/periph_rtc/Kconfig +++ b/tests/periph_rtc/Kconfig @@ -10,4 +10,3 @@ config APPLICATION default y imply MODULE_PERIPH_RTC_MEM imply MODULE_PERIPH_RTC_MS - imply MODULE_ZTIMER_NO_PERIPH_RTT From 29c6fecab36c395947a89df118dd7c15e746b78e Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 10:57:04 +0200 Subject: [PATCH 13/15] makefiles/features_modules: ignore non-init periphs --- makefiles/features_modules.inc.mk | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/makefiles/features_modules.inc.mk b/makefiles/features_modules.inc.mk index 86816ac725..a903aad5e1 100644 --- a/makefiles/features_modules.inc.mk +++ b/makefiles/features_modules.inc.mk @@ -14,7 +14,10 @@ PERIPH_IGNORE_MODULES := \ periph_clic \ periph_common \ periph_coretimer \ + periph_eth \ + periph_eth_common \ periph_flash \ + periph_flashpage_in_address_space \ periph_flexcomm \ periph_gpio_ll \ periph_gpio_ll_irq \ @@ -27,12 +30,15 @@ PERIPH_IGNORE_MODULES := \ periph_init% \ periph_mcg \ periph_mcg_lite \ + periph_nvm \ periph_plic \ periph_rtc_ms \ periph_rtc_rtt \ periph_rtt_hw_rtc \ periph_rtt_hw_sys \ periph_spi_on_qspi \ + periph_uart_collision \ + periph_uart_rxstart_irq \ periph_wdog \ # PERIPH_MODULES := $(filter-out $(PERIPH_IGNORE_MODULES),\ From e5000c8de1aecbed040293b2524744dcb8fa9b63 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 13:03:19 +0200 Subject: [PATCH 14/15] external_boards/nrf52840dk*: Rename to unique board --- .../boards_modded/{nrf52840dk => nrf52840dk_mod}/Kconfig | 1 + .../boards_modded/{nrf52840dk => nrf52840dk_mod}/Makefile | 0 .../boards_modded/{nrf52840dk => nrf52840dk_mod}/Makefile.dep | 0 .../{nrf52840dk => nrf52840dk_mod}/Makefile.features | 0 .../{nrf52840dk => nrf52840dk_mod}/Makefile.include | 0 .../boards_modded/{nrf52840dk => nrf52840dk_mod}/include/board.h | 0 .../{nrf52840dk => nrf52840dk_mod}/include/periph_conf.h | 0 7 files changed, 1 insertion(+) rename tests/periph_qdec/boards_modded/{nrf52840dk => nrf52840dk_mod}/Kconfig (91%) rename tests/periph_qdec/boards_modded/{nrf52840dk => nrf52840dk_mod}/Makefile (100%) rename tests/periph_qdec/boards_modded/{nrf52840dk => nrf52840dk_mod}/Makefile.dep (100%) rename tests/periph_qdec/boards_modded/{nrf52840dk => nrf52840dk_mod}/Makefile.features (100%) rename tests/periph_qdec/boards_modded/{nrf52840dk => nrf52840dk_mod}/Makefile.include (100%) rename tests/periph_qdec/boards_modded/{nrf52840dk => nrf52840dk_mod}/include/board.h (100%) rename tests/periph_qdec/boards_modded/{nrf52840dk => nrf52840dk_mod}/include/periph_conf.h (100%) diff --git a/tests/periph_qdec/boards_modded/nrf52840dk/Kconfig b/tests/periph_qdec/boards_modded/nrf52840dk_mod/Kconfig similarity index 91% rename from tests/periph_qdec/boards_modded/nrf52840dk/Kconfig rename to tests/periph_qdec/boards_modded/nrf52840dk_mod/Kconfig index 787b866418..4d477d829a 100644 --- a/tests/periph_qdec/boards_modded/nrf52840dk/Kconfig +++ b/tests/periph_qdec/boards_modded/nrf52840dk_mod/Kconfig @@ -19,5 +19,6 @@ config BOARD_NRF52840DK select HAVE_MTD_SPI_NOR select MODULE_BOARDS_COMMON_NRF52XXXDK if TEST_KCONFIG + select MODULE_BOARD_NRF52840DK_QDEC if TEST_KCONFIG source "$(RIOTBOARD)/common/nrf52xxxdk/Kconfig" diff --git a/tests/periph_qdec/boards_modded/nrf52840dk/Makefile b/tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile similarity index 100% rename from tests/periph_qdec/boards_modded/nrf52840dk/Makefile rename to tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile diff --git a/tests/periph_qdec/boards_modded/nrf52840dk/Makefile.dep b/tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile.dep similarity index 100% rename from tests/periph_qdec/boards_modded/nrf52840dk/Makefile.dep rename to tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile.dep diff --git a/tests/periph_qdec/boards_modded/nrf52840dk/Makefile.features b/tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile.features similarity index 100% rename from tests/periph_qdec/boards_modded/nrf52840dk/Makefile.features rename to tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile.features diff --git a/tests/periph_qdec/boards_modded/nrf52840dk/Makefile.include b/tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile.include similarity index 100% rename from tests/periph_qdec/boards_modded/nrf52840dk/Makefile.include rename to tests/periph_qdec/boards_modded/nrf52840dk_mod/Makefile.include diff --git a/tests/periph_qdec/boards_modded/nrf52840dk/include/board.h b/tests/periph_qdec/boards_modded/nrf52840dk_mod/include/board.h similarity index 100% rename from tests/periph_qdec/boards_modded/nrf52840dk/include/board.h rename to tests/periph_qdec/boards_modded/nrf52840dk_mod/include/board.h diff --git a/tests/periph_qdec/boards_modded/nrf52840dk/include/periph_conf.h b/tests/periph_qdec/boards_modded/nrf52840dk_mod/include/periph_conf.h similarity index 100% rename from tests/periph_qdec/boards_modded/nrf52840dk/include/periph_conf.h rename to tests/periph_qdec/boards_modded/nrf52840dk_mod/include/periph_conf.h From a00060f4d897328e4df107daff192bf44620dbca Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 16 Aug 2022 13:10:07 +0200 Subject: [PATCH 15/15] tests/periph_pm: Fix kconfig model --- tests/periph_pm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/periph_pm/Kconfig b/tests/periph_pm/Kconfig index 7a0f8866e2..021a1e6040 100644 --- a/tests/periph_pm/Kconfig +++ b/tests/periph_pm/Kconfig @@ -11,5 +11,4 @@ config APPLICATION imply MODULE_PERIPH_RTC imply MODULE_PERIPH_GPIO imply MODULE_PERIPH_GPIO_IRQ - imply MODULE_ZTIMER_NO_PERIPH_RTT if CPU_COMMON_SAM0 depends on TEST_KCONFIG