From 37dceb6c80c3e583a78f43fa45064a5abcd6898d Mon Sep 17 00:00:00 2001 From: Benjamin Valentin Date: Mon, 5 Sep 2022 02:41:45 +0200 Subject: [PATCH] nanocoap_sock: use correct error code in nanocoap_get_blockwise_url_to_buf() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It should return -ENOBUFS like the other nanocoap_…() functions, not -1 --- sys/include/net/nanocoap_sock.h | 3 ++- sys/net/application_layer/nanocoap/sock.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/include/net/nanocoap_sock.h b/sys/include/net/nanocoap_sock.h index 857d12c467..9fed27df04 100644 --- a/sys/include/net/nanocoap_sock.h +++ b/sys/include/net/nanocoap_sock.h @@ -308,8 +308,9 @@ int nanocoap_get_blockwise_url(const char *url, * @param[in] buf Target buffer * @param[in] len Target buffer length * + * @returns <0 on error * @returns -EINVAL if an invalid url is provided - * @returns -1 if failed to fetch the url content + * @returns -ENOBUFS if the provided buffer was too small * @returns size of the response payload on success */ ssize_t nanocoap_get_blockwise_url_to_buf(const char *url, diff --git a/sys/net/application_layer/nanocoap/sock.c b/sys/net/application_layer/nanocoap/sock.c index 645353e670..b3c05c410c 100644 --- a/sys/net/application_layer/nanocoap/sock.c +++ b/sys/net/application_layer/nanocoap/sock.c @@ -568,7 +568,7 @@ static int _2buf(void *arg, size_t offset, uint8_t *buf, size_t len, int more) _buf_t *dst = arg; if (offset + len > dst->len) { - return -1; + return -ENOBUFS; } memcpy(dst->ptr + offset, buf, len);