From 7b64d35af5a8dd0d52677a5690bbbba7ced6568b Mon Sep 17 00:00:00 2001 From: Evgeniy Krysanov Date: Wed, 5 Feb 2020 00:47:14 +0300 Subject: [PATCH 1/2] drivers/ds18: fix ds18 temperature conversion --- drivers/ds18/ds18.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ds18/ds18.c b/drivers/ds18/ds18.c index f1ea75583f..f1d0b16c90 100644 --- a/drivers/ds18/ds18.c +++ b/drivers/ds18/ds18.c @@ -184,8 +184,8 @@ int ds18_read(const ds18_t *dev, int16_t *temperature) DEBUG("[DS18] Received byte: 0x%02x\n", b2); - int32_t measurement = ((int16_t)(b2 << 8 | b1) * 625); - *temperature = (int16_t)(measurement / 100); + int32_t measurement = (int16_t)(b2 << 8 | b1); + *temperature = (int16_t)((100 * measurement) >> 4); return DS18_OK; } From 234313a9f1442a8fe6eaacc140e9b2cdeec1fafc Mon Sep 17 00:00:00 2001 From: Evgeniy Krysanov Date: Fri, 7 Feb 2020 12:55:43 +0300 Subject: [PATCH 2/2] drivers/ds18: add arduino-nano to BOARD_WHITELIST in ds18 driver test --- tests/driver_ds18/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/driver_ds18/Makefile b/tests/driver_ds18/Makefile index a444c7d0fd..a4a08ea198 100644 --- a/tests/driver_ds18/Makefile +++ b/tests/driver_ds18/Makefile @@ -1,6 +1,6 @@ include ../Makefile.tests_common -BOARD_WHITELIST := sensebox_samd21 samr21-xpro nucleo-l152re nucleo-l432kc nucleo-l073rz b-l072z-lrwan +BOARD_WHITELIST := sensebox_samd21 samr21-xpro nucleo-l152re nucleo-l432kc nucleo-l073rz b-l072z-lrwan arduino-nano USEMODULE += ds18 USEMODULE += xtimer