From 6c2d8f7a145de7eaa8447487ae8195ee6cccbfd5 Mon Sep 17 00:00:00 2001 From: "Martine S. Lenders" Date: Thu, 9 Jul 2020 15:40:13 +0200 Subject: [PATCH] riotctrl_shell.tests: add regression test for non-str ifconfig_set() --- .../riotctrl_shell/tests/test_netif.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/dist/pythonlibs/riotctrl_shell/tests/test_netif.py b/dist/pythonlibs/riotctrl_shell/tests/test_netif.py index c15c1bd7d2..b9e66fd7c8 100644 --- a/dist/pythonlibs/riotctrl_shell/tests/test_netif.py +++ b/dist/pythonlibs/riotctrl_shell/tests/test_netif.py @@ -76,12 +76,18 @@ def test_ifconfig_help(): assert res == "ifconfig foobar help" -def test_ifconfig_set(): - rc = init_ctrl(output="success: address set") +@pytest.mark.parametrize( + "option,value,expected", + [("addr", "42:de:ad:c0:ff:ee", + "ifconfig foobar set addr 42:de:ad:c0:ff:ee"), + ("chan", 17, "ifconfig foobar set chan 17")] +) +def test_ifconfig_set(option, value, expected): + rc = init_ctrl(output="success: option set") si = riotctrl_shell.netif.Ifconfig(rc) - res = si.ifconfig_set("foobar", "addr", "42:de:ad:c0:ff:ee") - assert res == "success: address set" - assert rc.term.last_command == "ifconfig foobar set addr 42:de:ad:c0:ff:ee" + res = si.ifconfig_set("foobar", option, value) + assert res == "success: option set" + assert rc.term.last_command == expected def test_ifconfig_set_error():