kaspar/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-24 14:03:55 +01:00
Code Releases Activity

gnrc_icmpv6_error: don't release orig_pkt on error

Browse Source 
The stack might still wants to do something with the packet after
copying it to the error message.
This commit is contained in:
Martine Lenders 2018-11-14 14:20:16 +01:00
parent 3b56c78a3b
commit 6ec456b0fc
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c
View File

@ -128,11 +128,6 @@ void gnrc_icmpv6_error_dst_unr_send(uint8_t code, gnrc_pktsnip_t *orig_pkt)
if (pkt != NULL) {
gnrc_netapi_send(gnrc_ipv6_pid, pkt);
}
#ifdef MODULE_GNRC_PKTBUF
gnrc_pktbuf_release_error(orig_pkt, EHOSTUNREACH);
#else
(void)orig_pkt;
#endif
}
void gnrc_icmpv6_error_pkt_too_big_send(uint32_t mtu, gnrc_pktsnip_t *orig_pkt)
@ -142,11 +137,6 @@ void gnrc_icmpv6_error_pkt_too_big_send(uint32_t mtu, gnrc_pktsnip_t *orig_pkt)
if (pkt != NULL) {
gnrc_netapi_send(gnrc_ipv6_pid, pkt);
}
#ifdef MODULE_GNRC_PKTBUF
gnrc_pktbuf_release_error(orig_pkt, EMSGSIZE);
#else
(void)orig_pkt;
#endif
}
void gnrc_icmpv6_error_time_exc_send(uint8_t code, gnrc_pktsnip_t *orig_pkt)
@ -156,11 +146,6 @@ void gnrc_icmpv6_error_time_exc_send(uint8_t code, gnrc_pktsnip_t *orig_pkt)
if (pkt != NULL) {
gnrc_netapi_send(gnrc_ipv6_pid, pkt);
}
#ifdef MODULE_GNRC_PKTBUF
gnrc_pktbuf_release_error(orig_pkt, ETIMEDOUT);
#else
(void)orig_pkt;
#endif
}
void gnrc_icmpv6_error_param_prob_send(uint8_t code, void *ptr,
@ -171,11 +156,6 @@ void gnrc_icmpv6_error_param_prob_send(uint8_t code, void *ptr,
if (pkt != NULL) {
gnrc_netapi_send(gnrc_ipv6_pid, pkt);
}
#ifdef MODULE_GNRC_PKTBUF
gnrc_pktbuf_release_error(orig_pkt, EINVAL);
#else
(void)orig_pkt;
#endif
}
/** @} */