kaspar/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-26 06:53:52 +01:00
Code Releases Activity

cpu/stm32: Fix periph_eth link status

Browse Source 
The link status was previously not returned via the value parameter, as required
by the netdev_driver_t API. As a result, e.g. the `ifconfig` shell command
showed garbage.
This commit is contained in:
Marian Buschsieweke 2020-10-05 16:30:57 +02:00
parent e9af7f9415
commit 7b738a66c4
No known key found for this signature in database
GPG Key ID: 61F64C6599B1539F
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
cpu/stm32/periph/eth.c
View File

@ -135,6 +135,11 @@ static inline void _phy_write(uint16_t addr, uint8_t reg, uint16_t value)
_rw_phy(addr, reg, (value & 0xffff) | (ETH_MACMIIAR_MW << 16));
}
static inline bool _get_link_status(void)
{
return (_phy_read(0, PHY_BSMR) & BSMR_LINK_STATUS);
}
static void stm32_eth_get_addr(char *out)
{
unsigned t;
@ -216,7 +221,12 @@ static int stm32_eth_get(netdev_t *dev, netopt_t opt,
res = ETHERNET_ADDR_LEN;
break;
case NETOPT_LINK:
res = (_phy_read(0, PHY_BSMR) & BSMR_LINK_STATUS);
assert(max_len == sizeof(netopt_enable_t));
{
netopt_enable_t tmp = _get_link_status();
memcpy(value, &tmp, sizeof(tmp));
}
res = sizeof(netopt_enable_t);
break;
default:
res = netdev_eth_get(dev, opt, value, max_len);
@ -230,7 +240,7 @@ static int stm32_eth_get(netdev_t *dev, netopt_t opt,
static void _timer_cb(void *arg)
{
netdev_t *dev = (netdev_t *)arg;
if (stm32_eth_get(dev, NETOPT_LINK, NULL, 0)) {
if (_get_link_status()) {
_link_state = LINK_STATE_UP;
dev->event_callback(dev, NETDEV_EVENT_ISR);
}