kaspar/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-31 09:21:19 +01:00
Code Releases Activity

Merge #19384

Browse Source 
19384: sam0/usbdev: partial revert of #17086 r=gschorcht a=dylad

### Contribution description
Reverting theses changes from #17086 because it breaks SAM0 `usbdev` in master.
The idea was to following the USB spec but for not obvious reason yet, it doesn't work as intended.
So revert these changes so `usbdev` works again on master.
We will try to figured out what's wrong later.


### Testing procedure
Test any `usbus` related test application w/ a SAM0-based board.


### Issues/PRs references
See discussion in #17086 


Co-authored-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
This commit is contained in:
bors[bot] 2023-03-13 13:33:58 +00:00 committed by GitHub
commit 993e539651
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cpu/sam0_common/periph/usbdev.c
View File

@ -584,14 +584,12 @@ static inline void _enable_ep_stall_in(UsbDeviceEndpoint *ep_reg)
static inline void _disable_ep_stall_out(UsbDeviceEndpoint *ep_reg)
{
ep_reg->EPSTATUSCLR.reg = USB_DEVICE_EPSTATUSCLR_STALLRQ0 |
USB_DEVICE_EPSTATUSCLR_DTGLOUT;
ep_reg->EPSTATUSCLR.reg = USB_DEVICE_EPSTATUSCLR_STALLRQ0;
}
static inline void _disable_ep_stall_in(UsbDeviceEndpoint *ep_reg)
{
ep_reg->EPSTATUSCLR.reg = USB_DEVICE_EPSTATUSCLR_STALLRQ1 |
USB_DEVICE_EPSTATUSCLR_DTGLIN;
ep_reg->EPSTATUSCLR.reg = USB_DEVICE_EPSTATUSCLR_STALLRQ1;
}
static void _usbdev_ep0_stall(usbdev_t *usbdev)