kaspar/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-23 05:23:50 +01:00
Code Releases Activity

destiny: deleting packed attribute from socket_internal_t

Browse Source 
While testing the tcp implementation on MSBA2 I noticed that
the value of `tcp_input_buffer_end` gets changed whenever acquiring or
releasing the mutex of the struct on the server side.

After deleting the packed attribute of the struct this problem was
resolved and the value stayed the same after acquiring and releasing.

This problem could maybe arise from badly placed cache lines due to
missing padding... I am not sure.

Anyway, I guess using the packed attribute is useless here and makes it
more error-prone.
This commit is contained in:
Cenk Gündoğan 2014-07-08 20:40:55 +02:00
parent 282ddc98fe
commit b5e7460d45
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/net/transport_layer/destiny/socket.h
View File

@ -59,7 +59,7 @@ typedef struct __attribute__((packed)) {
sockaddr6_t foreign_address; sockaddr6_t foreign_address;
} socket_t; } socket_t;
typedef struct __attribute__((packed)) { typedef struct {
uint8_t socket_id; uint8_t socket_id;
uint8_t recv_pid; uint8_t recv_pid;
uint8_t send_pid; uint8_t send_pid;