kaspar/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-16 01:53:51 +01:00
Code Releases Activity

cppcheck: output all annotations as error on script error

Browse Source 
`cppcheck` has a non-zero exit code even on warnings, so to not confuse
contributors, align the annotation output with that.
This commit is contained in:
Martine Lenders 2021-11-04 13:29:13 +01:00
parent b0d5e9a027
commit ca32d7704f
No known key found for this signature in database
GPG Key ID: 2134D77A5336DD80
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dist/tools/cppcheck/check.sh vendored
View File

@ -80,7 +80,10 @@ if github_annotate_is_on; then
DETAILS="${DETAILS} * (reason: <your reason why you think this is "
DETAILS="${DETAILS}a false positive>) */\n"
if echo "${SEVERITY}" | grep -q "\<error\>"; then
# contributors get confused if CI errors (i.e. non-zero result), but outputs only warnings
# => make all warnings errors on non-zero output. Otherwise, use severity level of output
# to determine annotation type.
if [ ${RESULT} -ne 0 ] || echo "${SEVERITY}" | grep -q "\<error\>"; then
github_annotate_error "${FILE}" "${LINENUM}" "${DETAILS}"
else
github_annotate_warning "${FILE}" "${LINENUM}" "${DETAILS}"