From d91c9cdc5a8b4bb3d70026d39dc04f8a10c8ec32 Mon Sep 17 00:00:00 2001 From: Marian Buschsieweke Date: Tue, 16 Nov 2021 16:20:26 +0100 Subject: [PATCH] cpu/atmega_common: make cppcheck happy --- cpu/atmega_common/periph/gpio.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cpu/atmega_common/periph/gpio.c b/cpu/atmega_common/periph/gpio.c index 87ea80cbab..7a415962bf 100644 --- a/cpu/atmega_common/periph/gpio.c +++ b/cpu/atmega_common/periph/gpio.c @@ -337,16 +337,17 @@ int gpio_init_int(gpio_t pin, gpio_mode_t mode, gpio_flank_t flank, EIMSK |= (1 << int_num); /* apply flank to interrupt number int_num */ - if (int_num < 4) { - EICRA &= ~(0x3 << (int_num * 2)); - EICRA |= (flank << (int_num * 2)); - } #if defined(EICRB) - else { + if (int_num >= 4) { EICRB &= ~(0x3 << ((int_num % 4) * 2)); EICRB |= (flank << ((int_num % 4) * 2)); } + else #endif + { + EICRA &= ~(0x3 << (int_num * 2)); + EICRA |= (flank << (int_num * 2)); + } /* set callback */ config[int_num].cb = cb;