From 5dd548860c1cad23922268c1b11d8766399cfee6 Mon Sep 17 00:00:00 2001 From: Marian Buschsieweke Date: Wed, 7 Jun 2023 15:10:33 +0200 Subject: [PATCH 1/2] drivers/mrf24j40: add note about missing wake pin handling Fixes https://github.com/RIOT-OS/RIOT/issues/19711 --- drivers/include/mrf24j40.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/include/mrf24j40.h b/drivers/include/mrf24j40.h index 87ab8d335f..613ef38cc3 100644 --- a/drivers/include/mrf24j40.h +++ b/drivers/include/mrf24j40.h @@ -14,6 +14,13 @@ * This module contains drivers for radio devices in Microchip MRF24J40 series. * The driver is aimed to work with all devices of this series. * + * @warning This driver doesn't handle the wake pin. As of now, it is + * required that the wake pin is high prior to the initialization + * (e.g. by connecting it to VCC in the board design). + * @note A PR extending @ref mrf24j40_params_t to contain the wake pin + * and adding appropriate handling of the wake pin to the driver + * logic would be a welcome addition. + * * Default TX power is 0dBm. * * TX power mapping: From c7f9237aa33131713fe86bf7f1ce622b28b6b2ad Mon Sep 17 00:00:00 2001 From: Marian Buschsieweke Date: Wed, 7 Jun 2023 15:19:50 +0200 Subject: [PATCH 2/2] boards/olimex-msp430-h1611: fix doc The statement about the missing pin 1 marking on the JTAG header is not correct. It's just a bit hidden between the JTAG header and the power selector jumper. --- boards/olimex-msp430-h1611/doc.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/boards/olimex-msp430-h1611/doc.txt b/boards/olimex-msp430-h1611/doc.txt index a19e1873a5..4d2d368734 100644 --- a/boards/olimex-msp430-h1611/doc.txt +++ b/boards/olimex-msp430-h1611/doc.txt @@ -66,9 +66,9 @@ among the less expensive options. @warning A jumper in `P_OUT` is mutually exclusive to a jumper in `P_IN`. Never connect both at the same time. -@note While the JTAG connector has no markings, you can easily spot pin 1 - on to bottom of the board by the square pad; all other JTAG pins - have a circular pad. +@note Pin 1 on the JTAG connector has a small white triangle next to it + and square pad, compared to the round pad used by all other JTAG + pins. Once the jumper is correctly placed in either `P_IN` or in `P_OUT` and the JTAG cable is connected just run