1
0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2026-01-01 01:41:18 +01:00
Marian Buschsieweke 8854255d7a
tests/bitarithm_timings: Fix use of volatile
The tests used the volatile qualifier for two this:

1.  Prevent the compiler to optimize out calls to the inline-able functions
    bitarithm_msb, bitarithm_lsb, bitarithm_bits_set
2.  Communication between IRQ context and thread context

While the first use is valid, the second is dangerous, see [1], [2], [3], [4].
This commit replaces the second use with C11 atomics, which were explicitly
added to the C standard to address this use case.

[1]: https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html
[2]: http://c.isvolatileusefulwiththreads.com/
[3]: https://web.archive.org/web/20181124154026/http://software.intel.com/en-us/blogs/2007/11/30/volatile-almost-useless-for-multi-threaded-programming/
[4]: https://blog.regehr.org/archives/28
2019-11-15 09:22:18 +01:00
..
2019-10-10 10:47:38 +02:00
2019-10-10 10:47:38 +02:00
2019-10-10 10:47:38 +02:00
2019-10-10 10:47:38 +02:00
2018-06-11 19:12:02 +02:00
2019-09-13 00:35:47 +02:00
2018-06-11 19:12:02 +02:00
2018-12-04 00:01:42 +01:00

Running and creating tests

There are a number of tests included in RIOT. They are located in the tests folder. These tests allow basic functionality to be verified as well as provide an example of usage.

Running automated tests

Some tests can be performed automatically. The test automation scripts are defined in the <test_application>/tests/ folder. They are written in python and interact through the uart with the test application code running on a board to do the validation. It is recommended to flash the board with the test just before running it because some platforms cannot be reset while testing.

From the test application directory run:

BOARD=<board_of_your_choice> make flash test

An automated way of knowing if a test is available is to execute the 'test/available' target from the test application directory. It executes without error if tests run by 'make test' are present.

make test/available

Interaction through the uart

Tests implemented with testrunner use the cleanterm target that provides an interaction without adding extra text output or input handling. It can currently be expected to have unmodified line based interaction with the board.

The expected behavior is verified with the test in tests/test_tools.

Tests cannot rely on having on all boards and terminal programs:

  • unbuffered input
  • allowing sending special characters like ctrl+c/ctrl+d