1
0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-12-31 17:31:18 +01:00
bors[bot] 211db05401
Merge #18477 #19101 #19155
18477: gnrc_static: add static network configuration r=miri64 a=benpicco



19101: CI: update check-labels-action r=miri64 a=kaspar030



19155: Revert "sys/pm_layered: pm_(un)block add attribute optimize(3)" r=maribu a=Teufelchen1

Revert "sys/pm_layered: pm_(un)block add attribute optimize(3) -shortens hotpath"

This reverts commit 5447203921ab39962d7d378a631a6bc048e7f30b.

### Contribution description

Compiling `examples/gnrc_networking_mac` using `TOOLCHAIN=llvm` yields the following error:
```
RIOT/sys/pm_layered/pm.c:77:16: error: unknown attribute 'optimize' ignored [-Werror,-Wunknown-attributes]
__attribute__((optimize(3)))
```
As indicated, this is because the attribute `optimize` is GCC only and not present in LLVM.
Compare the manpages of [GCC](https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html) and [LLVM](https://clang.llvm.org/docs/AttributeReference.html).


### Testing procedure

Since this should only affect performance and not behavior, no special testing is needed. I am not aware of any tests in RIOT which could verify that assumption.

### Issues/PRs references

Introduced in #18846

There is another instance of this attribute being used in[ shell_lock.c](6fb340d654/sys/shell_lock/shell_lock.c (L80)). Since the usage is security related, I omit it from this PR.


Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
Co-authored-by: Kaspar Schleiser <kaspar@schleiser.de>
Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
2023-01-16 14:03:15 +00:00
..
2023-01-13 13:58:07 +01:00
2022-09-14 15:05:25 +02:00
2022-09-23 16:42:52 +02:00
2023-01-16 14:03:15 +00:00
2022-02-11 12:38:21 +01:00
2022-09-05 07:46:56 +02:00
2020-11-12 22:50:53 +01:00
2022-09-14 15:05:25 +02:00
2021-06-02 14:07:17 +02:00
2022-09-16 14:00:35 +02:00
2021-12-15 12:41:36 +01:00
2023-01-13 13:58:07 +01:00
2022-11-15 22:05:42 +01:00
2020-10-22 11:10:14 +02:00
2022-12-19 13:03:45 +01:00
2021-08-13 19:50:38 +02:00
2023-01-13 13:58:07 +01:00
2021-12-07 13:00:58 +01:00
2021-08-13 19:50:38 +02:00
2020-11-17 10:10:28 +01:00
2022-12-05 16:13:21 +01:00
2022-07-26 19:46:14 +02:00
2021-01-17 00:17:58 +01:00
2022-11-22 13:39:35 +01:00
2022-11-22 13:39:35 +01:00
2021-08-13 19:50:38 +02:00
2021-12-06 11:53:59 +01:00
2022-02-12 18:30:58 +01:00
2021-08-13 19:50:38 +02:00
2022-08-03 22:09:21 +02:00
2022-09-29 22:01:37 +02:00