riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #14561 from benpicco/cpu/lpc23xx-bitarithm_test_and_clear

Browse Source 
cpu/lpc23xx: GPIO: use bitarithm_test_and_clear()
This commit is contained in:
Marian Buschsieweke 2020-07-28 16:17:35 +02:00 committed by GitHub
commit 0ad3a7c1cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cpu/lpc23xx/periph/gpio.c
View File

@ -26,6 +26,7 @@
#include "irq.h" #include "irq.h"
#include "periph/gpio.h" #include "periph/gpio.h"
#include "bitarithm.h"
#include "bitfield.h" #include "bitfield.h"
#define ENABLE_DEBUG (0) #define ENABLE_DEBUG (0)
@ -273,9 +274,10 @@ static void test_irq(int port, unsigned long active_pins)
/* Test each bit of rising and falling masks, if set trigger interrupt /* Test each bit of rising and falling masks, if set trigger interrupt
* on corresponding device */ * on corresponding device */
uint8_t pin = 0;
while (active_pins) { while (active_pins) {
/* we want the position of the first one bit, so N_bits - (N_leading_zeros + 1) */ /* get the index of the next set pin */
unsigned pin = 32 - __builtin_clz(active_pins) - 1; active_pins = bitarithm_test_and_clear(active_pins, &pin);
/* get the index of the configured interrupt */ /* get the index of the configured interrupt */
int _state_index = _gpio_isr_map[_isr_map_entry2(port, pin)]; int _state_index = _gpio_isr_map[_isr_map_entry2(port, pin)];
@ -284,9 +286,6 @@ static void test_irq(int port, unsigned long active_pins)
if (_state_index != 0xff) { if (_state_index != 0xff) {
_gpio_states[_state_index].cb(_gpio_states[_state_index].arg); _gpio_states[_state_index].cb(_gpio_states[_state_index].arg);
} }
/* clear bit */
active_pins &= ~(1 << pin);
} }
} }