From c277100dd9a5ed7692447309c052ce0f87195cbe Mon Sep 17 00:00:00 2001 From: Benjamin Valentin Date: Tue, 19 Nov 2019 22:36:07 +0100 Subject: [PATCH] boards/atmega_common: remove weak led_init() `led_init()` is already protected by an `#ifdef`, so no need for the weak symbol. The problem is that the weak function does not get overridden, even when the board provides it's own led_init(), resulting in no LEDs being initialized. --- boards/common/atmega/board.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/boards/common/atmega/board.c b/boards/common/atmega/board.c index e44c0fd742..17ce8c1884 100644 --- a/boards/common/atmega/board.c +++ b/boards/common/atmega/board.c @@ -29,13 +29,6 @@ void led_init(void); -/* - * Add an empty led_init() as fall back. - * If at link time another implementation of led_init() not marked as weak - * (a.k.a. a strong symbol) is present, it will be linked in instead. - */ -void __attribute__((weak)) led_init(void) {} - void board_init(void) { #ifdef CPU_ATMEGA32U4