riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sys/riotboot: add a warning about the size of riotboot_flashwrite_t

Browse Source 
On e.g. samd5x FLASHPAGE_SIZE is 8k (4k on kinetis, stm32w, nrf52)
so placing this struct on the stack will almost always cause a stack
overflow.
This commit is contained in:
Benjamin Valentin 2020-03-31 13:18:31 +02:00
parent 934f68ead8
commit 2867ab8b9b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/include/riotboot/flashwrite.h
View File

@ -59,6 +59,9 @@ extern "C" {
/** /**
* @brief firmware update state structure * @brief firmware update state structure
*
* @note @ref FLASHPAGE_SIZE can be very large on some platforms, don't place
* this struct on the stack or increase the thread stack size accordingly.
*/ */
typedef struct { typedef struct {
int target_slot; /**< update targets this slot */ int target_slot; /**< update targets this slot */