riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #12947 from gschorcht/cpu/esp32/fix_send_buffer

Browse Source 
cpu/esp32: esp_wifi send buffer should not be on stack
This commit is contained in:
benpicco 2019-12-14 11:21:26 +01:00 committed by GitHub
commit 2ed87d54bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cpu/esp32/esp-wifi/esp_wifi_netdev.c
View File

@ -347,6 +347,9 @@ static int _esp_wifi_init(netdev_t *netdev)
return 0; return 0;
} }
/* transmit buffer should bot be on stack */
static uint8_t _tx_buf[ETHERNET_MAX_LEN];
static int _esp_wifi_send(netdev_t *netdev, const iolist_t *iolist) static int _esp_wifi_send(netdev_t *netdev, const iolist_t *iolist)
{ {
ESP_WIFI_DEBUG("%p %p", netdev, iolist); ESP_WIFI_DEBUG("%p %p", netdev, iolist);
@ -360,7 +363,6 @@ static int _esp_wifi_send(netdev_t *netdev, const iolist_t *iolist)
} }
uint16_t tx_len = 0; /**< number of bytes in transmit buffer */ uint16_t tx_len = 0; /**< number of bytes in transmit buffer */
uint8_t tx_buf[ETHERNET_MAX_LEN]; /**< transmit buffer */
/* load packet data into TX buffer */ /* load packet data into TX buffer */
for (const iolist_t *iol = iolist; iol; iol = iol->iol_next) { for (const iolist_t *iol = iolist; iol; iol = iol->iol_next) {
@ -368,7 +370,7 @@ static int _esp_wifi_send(netdev_t *netdev, const iolist_t *iolist)
return -EOVERFLOW; return -EOVERFLOW;
} }
if (iol->iol_len) { if (iol->iol_len) {
memcpy (tx_buf + tx_len, iol->iol_base, iol->iol_len); memcpy (_tx_buf + tx_len, iol->iol_base, iol->iol_len);
tx_len += iol->iol_len; tx_len += iol->iol_len;
} }
} }