riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

drivers enc28j60: correctly initialize netstats

Browse Source 
Driver's netstats should be initialize in init, not isr...
This commit is contained in:
Oleg Hahm 2016-04-03 18:04:32 +02:00
parent 900528b2f2
commit 4ba73928ac
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/enc28j60/enc28j60.c
View File

@ -230,6 +230,7 @@ static int nd_send(netdev2_t *netdev, const struct iovec *data, int count)
#ifdef MODULE_NETSTATS_L2 #ifdef MODULE_NETSTATS_L2
netdev->stats.tx_bytes += count; netdev->stats.tx_bytes += count;
#endif #endif
/* set write pointer */ /* set write pointer */
cmd_w_addr(dev, ADDR_WRITE_PTR, BUF_TX_START); cmd_w_addr(dev, ADDR_WRITE_PTR, BUF_TX_START);
/* write control byte and the actual data into the buffer */ /* write control byte and the actual data into the buffer */
@ -380,6 +381,9 @@ static int nd_init(netdev2_t *netdev)
/* allow receiving bytes from now on */ /* allow receiving bytes from now on */
cmd_bfs(dev, REG_ECON1, -1, ECON1_RXEN); cmd_bfs(dev, REG_ECON1, -1, ECON1_RXEN);
#ifdef MODULE_NETSTATS_L2
memset(&netdev->stats, 0, sizeof(netstats_t));
#endif
mutex_unlock(&dev->devlock); mutex_unlock(&dev->devlock);
return 0; return 0;
} }
@ -424,9 +428,6 @@ static void nd_isr(netdev2_t *netdev)
} }
eir = cmd_rcr(dev, REG_EIR, -1); eir = cmd_rcr(dev, REG_EIR, -1);
} }
#ifdef MODULE_NETSTATS_L2
memset(&netdev->stats, 0, sizeof(netstats_t));
#endif
} }
static int nd_get(netdev2_t *netdev, netopt_t opt, void *value, size_t max_len) static int nd_get(netdev2_t *netdev, netopt_t opt, void *value, size_t max_len)