riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "cpu/sam0_common: UART: implement inverted RX & TX"

Browse Source 
This reverts commit 585dc15f99d8a89766bb12d064fa2209909a1b6d.

I did misunderstand this feature: This only inverts the data
bits (instead of `c` uart will transmit `~c`), not the whole
line level.

This is not very useful on it's own, so revert it.
This commit is contained in:
Benjamin Valentin 2020-10-12 01:29:17 +02:00 committed by Benjamin Valentin
parent 9b449fba98
commit 5f002ced1f
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cpu/sam0_common/include/periph_cpu_common.h
View File

@ -178,8 +178,6 @@ typedef enum {
UART_FLAG_NONE = 0x0, /**< No flags set */ UART_FLAG_NONE = 0x0, /**< No flags set */
UART_FLAG_RUN_STANDBY = 0x1, /**< run SERCOM in standby mode */ UART_FLAG_RUN_STANDBY = 0x1, /**< run SERCOM in standby mode */
UART_FLAG_WAKEUP = 0x2, /**< wake from sleep on receive */ UART_FLAG_WAKEUP = 0x2, /**< wake from sleep on receive */
UART_FLAG_RXINV = 0x4, /**< invert RX signal */
UART_FLAG_TXINV = 0x8, /**< invert TX signal */
} uart_flag_t; } uart_flag_t;
#ifndef DOXYGEN #ifndef DOXYGEN

12
cpu/sam0_common/periph/uart.c
View File

@ -190,18 +190,6 @@ int uart_init(uart_t uart, uint32_t baudrate, uart_rx_cb_t rx_cb, void *arg)
if (uart_config[uart].flags & UART_FLAG_RUN_STANDBY) { if (uart_config[uart].flags & UART_FLAG_RUN_STANDBY) {
dev(uart)->CTRLA.reg |= SERCOM_USART_CTRLA_RUNSTDBY; dev(uart)->CTRLA.reg |= SERCOM_USART_CTRLA_RUNSTDBY;
} }
#ifdef SERCOM_USART_CTRLA_RXINV
/* COM100-61: The TXINV and RXINV bits in the CTRLA register have inverted functionality. */
if (uart_config[uart].flags & UART_FLAG_TXINV) {
dev(uart)->CTRLA.reg |= SERCOM_USART_CTRLA_RXINV;
}
#endif
#ifdef SERCOM_USART_CTRLA_TXINV
/* COM100-61: The TXINV and RXINV bits in the CTRLA register have inverted functionality. */
if (uart_config[uart].flags & UART_FLAG_RXINV) {
dev(uart)->CTRLA.reg |= SERCOM_USART_CTRLA_TXINV;
}
#endif
/* calculate and set baudrate */ /* calculate and set baudrate */
_set_baud(uart, baudrate); _set_baud(uart, baudrate);