riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cppcheck: Don't Run cppcheck on ASM files.

Browse Source 
cppcheck doesn't understand ASM style comments beginning with '#' and tries to
parse them:

I get this error:
 cpu/mips_pic32_common/reset_mod.S:84: error (syntaxError): syntax error
from this line:
 beqz s1, init_resources # Branch if this is NOT an NMI exception.

If I place the comment inside C-style comments cppcheck passes, ie

 beqz s1, init_resources # /*Branch if this is NOT an NMI exception.*/

Note current in-tree ASM files fail cppcheck (they must have been added before
this check) for example:

cpu/lpc2387/asmfunc.s
This commit is contained in:
Neil Jones 2017-03-29 15:06:43 +01:00
parent 76bae4b111
commit 65911f3499
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dist/tools/cppcheck/check.sh vendored
View File

@ -17,7 +17,7 @@ else
fi fi
BRANCH=${1} BRANCH=${1}
FILEREGEX='\.([CcHhSs]|[ch]pp)$' FILEREGEX='\.([CcHh]|[ch]pp)$'
EXCLUDE='^(.+/include/vendor/)' EXCLUDE='^(.+/include/vendor/)'
# If no branch but an option is given, unset BRANCH. # If no branch but an option is given, unset BRANCH.