Merge pull request #479 from LudwigOrtmann/nativenet_lenchck
Nativenet length check and cleanup
This commit is contained in:
commit
6fe1ecd1b4
@ -44,7 +44,7 @@ struct nativenet_header {
|
||||
|
||||
struct nativenet_packet {
|
||||
struct nativenet_header nn_header;
|
||||
unsigned char data[ETHERMTU - sizeof(struct nativenet_header)];
|
||||
uint8_t data[ETHERMTU - sizeof(struct nativenet_header)];
|
||||
} __attribute__((packed));
|
||||
|
||||
union eth_frame {
|
||||
|
||||
@ -91,10 +91,15 @@ void _native_handle_tap_input(void)
|
||||
/* XXX: check overflow */
|
||||
p.length = ntohs(frame.field.payload.nn_header.length);
|
||||
p.data = frame.field.payload.data;
|
||||
if (p.length > (nread - sizeof(struct nativenet_header))) {
|
||||
warnx("_native_handle_tap_input: packet with malicious length field received, discarding");
|
||||
}
|
||||
else {
|
||||
DEBUG("_native_handle_tap_input: received packet of length %"PRIu16" for %"PRIu16" from %"PRIu16"\n", p.length, p.dst, p.src);
|
||||
_nativenet_handle_packet(&p);
|
||||
}
|
||||
}
|
||||
}
|
||||
else {
|
||||
DEBUG("ignoring non-native frame\n");
|
||||
}
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user