Merge pull request #479 from LudwigOrtmann/nativenet_lenchck

Nativenet length check and cleanup
This commit is contained in:
Ludwig Ortmann 2014-01-10 01:47:35 -08:00
commit 6fe1ecd1b4
3 changed files with 9 additions and 4 deletions

View File

@ -44,7 +44,7 @@ struct nativenet_header {
struct nativenet_packet {
struct nativenet_header nn_header;
unsigned char data[ETHERMTU - sizeof(struct nativenet_header)];
uint8_t data[ETHERMTU - sizeof(struct nativenet_header)];
} __attribute__((packed));
union eth_frame {

View File

@ -91,8 +91,13 @@ void _native_handle_tap_input(void)
/* XXX: check overflow */
p.length = ntohs(frame.field.payload.nn_header.length);
p.data = frame.field.payload.data;
DEBUG("_native_handle_tap_input: received packet of length %"PRIu16" for %"PRIu16" from %"PRIu16"\n", p.length, p.dst, p.src);
_nativenet_handle_packet(&p);
if (p.length > (nread - sizeof(struct nativenet_header))) {
warnx("_native_handle_tap_input: packet with malicious length field received, discarding");
}
else {
DEBUG("_native_handle_tap_input: received packet of length %"PRIu16" for %"PRIu16" from %"PRIu16"\n", p.length, p.dst, p.src);
_nativenet_handle_packet(&p);
}
}
}
else {