riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ds1307: return error when nothing is read or written on initialization

Browse Source 
It hints at to an unconnected devices ;-)
This commit is contained in:
Martine Lenders 2017-10-23 14:41:04 +02:00
parent 775e2071e5
commit 8ce7ff2836
No known key found for this signature in database
GPG Key ID: 8E97A9FE55F25D62
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ds1307/ds1307.c
View File

@ -64,7 +64,7 @@ int ds1307_init(ds1307_t *dev, const ds1307_params_t *params)
} }
/* normalize hour format */ /* normalize hour format */
res = i2c_read_reg(dev->i2c, DS1307_I2C_ADDRESS, DS1307_REG_HOUR, &hour); res = i2c_read_reg(dev->i2c, DS1307_I2C_ADDRESS, DS1307_REG_HOUR, &hour);
if (res < 0) { if (res <= 0) { /* should be 1 if device is connected */
i2c_release(dev->i2c); i2c_release(dev->i2c);
DEBUG("ds1307: Error reading HOUR register on init: %i\n", res); DEBUG("ds1307: Error reading HOUR register on init: %i\n", res);
return -1; return -1;
@ -73,7 +73,7 @@ int ds1307_init(ds1307_t *dev, const ds1307_params_t *params)
_convert_12_to_24(hour)); _convert_12_to_24(hour));
i2c_release(dev->i2c); i2c_release(dev->i2c);
if (res < 0) { if (res <= 0) {
DEBUG("ds1307: Error writing HOUR register on init: %i\n", res); DEBUG("ds1307: Error writing HOUR register on init: %i\n", res);
return -1; return -1;
} }