riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

posix: sockets: address was not set in recvfrom

Browse Source 
The address is an optional parameter of recvfrom. If it is
not null, recvfrom must store the address of the sender.
However this was only allowed if res was equal to 0, which
is wrong since res contains the number of bytes received
or -1.
This commit ensures that the address is set only if no
previous errors happened before.

Signed-off-by: Francois Berder <francois.berder@imgtec.com>
This commit is contained in:
Francois Berder 2017-03-07 11:02:11 +00:00
parent 2936a69a1b
commit 8f839fbc31
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/posix/sockets/posix_sockets.c
View File

@ -826,7 +826,7 @@ ssize_t recvfrom(int socket, void *restrict buffer, size_t length, int flags,
res = -1;
break;
}
if ((res == 0) && (address != NULL) && (address_len != 0)) {
if ((res >= 0) && (address != NULL) && (address_len != 0)) {
switch (s->type) {
#ifdef MODULE_SOCK_TCP
case SOCK_STREAM: