From 9066ab28e19da2961423f9aa493ea1058094340f Mon Sep 17 00:00:00 2001
From: Martine Lenders <m.lenders@fu-berlin.de>
Date: Thu, 17 Dec 2020 15:08:34 +0100
Subject: [PATCH] make: run static_tests.sh directly with `static-tests` target

---
 dist/tools/ci/static_tests.sh |  6 +++---
 dist/tools/static-tests.sh    | 25 -------------------------
 makefiles/tests.inc.mk        |  2 +-
 3 files changed, 4 insertions(+), 29 deletions(-)
 delete mode 100755 dist/tools/static-tests.sh

diff --git a/dist/tools/ci/static_tests.sh b/dist/tools/ci/static_tests.sh
index 2e43ccdbda..bae2eaa36d 100755
--- a/dist/tools/ci/static_tests.sh
+++ b/dist/tools/ci/static_tests.sh
@@ -15,7 +15,7 @@
 declare -A DEPS
 
 DEPS["./dist/tools/licenses/check.sh"]="head pcregrep"
-DEPS["./dist/tools/doccheck/check.sh"]="doxygen tput snafu"
+DEPS["./dist/tools/doccheck/check.sh"]="doxygen tput"
 DEPS["./dist/tools/cppcheck/check.sh"]="cppcheck"
 DEPS["./dist/tools/vera++/check.sh"]="vera++"
 DEPS["./dist/tools/coccinelle/check.sh"]="spatch"
@@ -24,7 +24,7 @@ DEPS["./dist/tools/codespell/check.sh"]="codespell"
 DEPS["./dist/tools/uncrustify/uncrustify.sh"]="uncrustify"
 
 if ! command -v git 2>&1 1>/dev/null; then
-    echo -n "Required command 'git' for all static tests not found in PATH " >&2
+    echo -n "Required command 'git' for all static tests not found in PATH "
     print_warning
     set_result 1
     exit 1
@@ -61,7 +61,7 @@ set_result() {
 function run {
     for dep in ${DEPS["$1"]}; do
         if ! command -v ${dep} 2>&1 1>/dev/null; then
-            echo -n "Required command '${dep}' for '$*' not found in PATH " >&2
+            echo -n "Required command '${dep}' for '$*' not found in PATH "
             print_warning
             set_result 1
             return 1
diff --git a/dist/tools/static-tests.sh b/dist/tools/static-tests.sh
deleted file mode 100755
index 14db3a24e1..0000000000
--- a/dist/tools/static-tests.sh
+++ /dev/null
@@ -1,25 +0,0 @@
-#!/usr/bin/env bash
-#
-# Copyright (C) 2015 Lucas Jenß <lucas@x3ro.de>
-#
-# This file is subject to the terms and conditions of the GNU Lesser
-# General Public License v2.1. See the file LICENSE in the top level
-# directory for more details.
-#
-
-# Change to RIOT root
-cd "$(dirname "$0")/../../"
-
-function dep {
-    command -v $1 2>&1 1>/dev/null
-    if (( $? != 0 )); then
-        echo "Dependency not met: $1"
-        exit 1
-    fi
-}
-
-# Make sure all required commands are available
-dep cppcheck
-dep pcregrep
-
-BUILDTEST_MCU_GROUP=static-tests ./dist/tools/ci/build_and_test.sh
diff --git a/makefiles/tests.inc.mk b/makefiles/tests.inc.mk
index fd5e492ce6..85269dd720 100644
--- a/makefiles/tests.inc.mk
+++ b/makefiles/tests.inc.mk
@@ -1,3 +1,3 @@
 
 static-test:
-	./dist/tools/static-tests.sh
+	./dist/tools/ci/static_tests.sh