riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ci/build_system_check: improve check for features provided in Makefile.features

Browse Source 
- Take into account potential spaces at the beginning of a line
- Check all Makefile.<something> files, not only the ones in boards and cpus
This commit is contained in:
Alexandre Abadie 2020-07-14 16:22:55 +02:00
parent f013be5507
commit b7f2ad8d76
No known key found for this signature in database
GPG Key ID: 1C919A403CAE1405
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dist/tools/buildsystem_sanity_check/check.sh vendored
View File

@ -66,14 +66,14 @@ check_providing_features_only_makefile_features() {
local patterns=() local patterns=()
local pathspec=() local pathspec=()
patterns+=(-e 'FEATURES_PROVIDED *+= *') patterns+=(-e '^[ ]*FEATURES_PROVIDED *+= *')
pathspec+=("boards/*Makefile*" "cpu/*Makefile*") pathspec+=("*Makefile\.*")
pathspec+=(":!*Makefile.features") pathspec+=(":!*Makefile.features")
git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}" \ git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}" \
| error_with_message 'Features in cpu and boards should only be provided in Makefile.features files' | error_with_message 'Features should only be provided in Makefile.features files'
} }
# Some variables do not need to be exported and even cause issues when being # Some variables do not need to be exported and even cause issues when being