From be75f734d1ea6d27e33bb5fbf7ab2e4f664c4f5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABtan=20Harter?= Date: Wed, 23 Jan 2019 17:17:50 +0100 Subject: [PATCH] makefiles/vars.inc.mk: do not export LINKFLAGS It is only used by `Makefile.include` and should not be used by sub-make instances. This is required to prevent evaluating `LINKFLAGS` when not needed and a required step to not evaluate it on the host with for example `avr-ld` when building in docker. I checked usage with: git grep -e '(LINKFLAGS)' -e '{LINKFLAGS}' Packages may be using it but `LINKFLAGS` is a RIOT way of naming things and even if `generate-xcompile-toolchain` uses `LINK` it does not use `LINKFLAGS`. --- makefiles/vars.inc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/makefiles/vars.inc.mk b/makefiles/vars.inc.mk index cff66ea75b..1344662348 100644 --- a/makefiles/vars.inc.mk +++ b/makefiles/vars.inc.mk @@ -56,7 +56,7 @@ export ARFLAGS # Command-line options to pass to AR, default `rcs` export AS # The assembler. export ASFLAGS # Flags for the assembler. export LINK # The command used to link the files. Must take the same parameters as GCC, i.e. "ld" won't work. -export LINKFLAGS # Flags to supply in the linking step. +# LINKFLAGS # Flags to supply in the linking step. export LTOFLAGS # extra CFLAGS for compiling with link time optimization export OBJCOPY # The command used to create the HEXFILE. export OFLAGS # The parameter for OBJCOPY, e.g. to strip the debug information.