riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/sys_atomic_utils_unittests: spice up test

Browse Source 
Initializing the state variables per loop with a value where some bits are set
and some are cleared makes much more sense. E.g. previously the bitwise and
applied on the state variable initialized with zero was unlikely to detect
implementation issues, as the state value never changed. So if the bitwise
and would be incorrectly implemented as a nop, it would have passed the unit
test.
This commit is contained in:
Marian Buschsieweke 2020-12-16 10:13:43 +01:00
parent ab477a94b0
commit c015e64e8e
No known key found for this signature in database
GPG Key ID: 61F64C6599B1539F
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/sys_atomic_utils_unittests/main.c
View File

@ -55,9 +55,9 @@ static void test_load_store(void)
static void test_fetch_op_u8(fetch_op_u8_t atomic_op, fetch_op_u8_t op) static void test_fetch_op_u8(fetch_op_u8_t atomic_op, fetch_op_u8_t op)
{ {
uint8_t state1 = 0, state2 = 0;
uint8_t i = 0; uint8_t i = 0;
do { do {
uint8_t state1 = 0x55, state2 = 0x55;
atomic_op(&state1, i); atomic_op(&state1, i);
op(&state2, i); op(&state2, i);
TEST_ASSERT_EQUAL_INT(state1, state2); TEST_ASSERT_EQUAL_INT(state1, state2);
@ -81,9 +81,9 @@ static void test_fetch_ops_u8(void)
static void test_fetch_op_u16(fetch_op_u16_t atomic_op, fetch_op_u16_t op) static void test_fetch_op_u16(fetch_op_u16_t atomic_op, fetch_op_u16_t op)
{ {
uint16_t state1 = 0, state2 = 0;
uint8_t i = 0; uint8_t i = 0;
do { do {
uint16_t state1 = 0x5555, state2 = 0x5555;
uint16_t num = random_uint32(); uint16_t num = random_uint32();
atomic_op(&state1, num); atomic_op(&state1, num);
op(&state2, num); op(&state2, num);
@ -108,9 +108,9 @@ static void test_fetch_ops_u16(void)
static void test_fetch_op_u32(fetch_op_u32_t atomic_op, fetch_op_u32_t op) static void test_fetch_op_u32(fetch_op_u32_t atomic_op, fetch_op_u32_t op)
{ {
uint32_t state1 = 0, state2 = 0;
uint8_t i = 0; uint8_t i = 0;
do { do {
uint32_t state1 = 0x55555555, state2 = 0x55555555;
uint32_t num = random_uint32(); uint32_t num = random_uint32();
atomic_op(&state1, num); atomic_op(&state1, num);
op(&state2, num); op(&state2, num);
@ -135,9 +135,10 @@ static void test_fetch_ops_u32(void)
static void test_fetch_op_u64(fetch_op_u64_t atomic_op, fetch_op_u64_t op) static void test_fetch_op_u64(fetch_op_u64_t atomic_op, fetch_op_u64_t op)
{ {
uint64_t state1 = 0, state2 = 0;
uint8_t i = 0; uint8_t i = 0;
do { do {
uint64_t state1, state2;
state1 = state2 = 0x5555555555555555;
uint64_t num; uint64_t num;
random_bytes((void *)&num, sizeof(num)); random_bytes((void *)&num, sizeof(num));
atomic_op(&state1, num); atomic_op(&state1, num);