From c851ec60b83b62a0da74492ec346e9edb6627b2e Mon Sep 17 00:00:00 2001
From: Martine Lenders <m.lenders@fu-berlin.de>
Date: Tue, 23 Feb 2021 11:26:25 +0100
Subject: [PATCH] buildsystem_sanity_check: Check for RIOT_CONFIG_* variables

---
 dist/tools/buildsystem_sanity_check/check.sh | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/dist/tools/buildsystem_sanity_check/check.sh b/dist/tools/buildsystem_sanity_check/check.sh
index 99fb11f786..17b1398998 100755
--- a/dist/tools/buildsystem_sanity_check/check.sh
+++ b/dist/tools/buildsystem_sanity_check/check.sh
@@ -334,6 +334,20 @@ check_no_pkg_source_local() {
         | error_with_message "Don't push PKG_SOURCE_LOCAL definitions upstream"
 }
 
+check_no_riot_config() {
+    local patterns=()
+    local pathspec=()
+
+    patterns+=(-e 'RIOT_CONFIG_.*')
+
+    pathspec+=('Makefile*')
+    pathspec+=('**/Makefile*')
+    pathspec+=('**/*.mk')
+    pathspec+=(':!makefiles/kconfig.mk')
+    git -C "${RIOTBASE}" grep -n "${patterns[@]}" -- "${pathspec[@]}" \
+        | error_with_message "Don't push RIOT_CONFIG_* definitions upstream. Rather define configuration via Kconfig"
+}
+
 error_on_input() {
     ! grep ''
 }
@@ -353,6 +367,7 @@ all_checks() {
     check_no_pseudomodules_in_makefile_dep
     check_no_usemodules_in_makefile_include
     check_no_pkg_source_local
+    check_no_riot_config
 }
 
 main() {