riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/periph_uart_mode: Drop dep to periph_timer

Browse Source 
Use xtimer only optionally (when periph_timer is available) for the
test. This makes this test applicable to freshly ported boards that
do not yet have a peripheral timer driver.
This commit is contained in:
Marian Buschsieweke 2021-07-13 16:51:00 +02:00
parent c2e9bc5c73
commit ca7c12643c
No known key found for this signature in database
GPG Key ID: 61F64C6599B1539F
3 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/periph_uart_mode/Makefile
View File

@ -2,8 +2,7 @@ include ../Makefile.tests_common
FEATURES_REQUIRED += periph_uart FEATURES_REQUIRED += periph_uart
FEATURES_REQUIRED += periph_uart_modecfg FEATURES_REQUIRED += periph_uart_modecfg
FEATURES_OPTIONAL += periph_timer
USEMODULE += xtimer
# Set this to prevent welcome message from printing and confusing output # Set this to prevent welcome message from printing and confusing output
CFLAGS+=-DLOG_LEVEL=LOG_NONE CFLAGS+=-DLOG_LEVEL=LOG_NONE

3
tests/periph_uart_mode/Makefile.board.dep Normal file
View File

@ -0,0 +1,3 @@
ifneq (,$(filter periph_timer,$(FEATURES_USED)))
USEMODULE += xtimer
endif

23
tests/periph_uart_mode/main.c
View File

@ -22,7 +22,9 @@
#include <string.h> #include <string.h>
#include <stdlib.h> #include <stdlib.h>
#include "board.h"
#include "periph/uart.h" #include "periph/uart.h"
#include "periph_conf.h"
#include "stdio_uart.h" #include "stdio_uart.h"
#include "xtimer.h" #include "xtimer.h"
@ -52,6 +54,25 @@
/* Stores each mode string for printing at the end of the test */ /* Stores each mode string for printing at the end of the test */
static char mode_strings[TOTAL_OPTIONS][MODE_STR_LEN]; static char mode_strings[TOTAL_OPTIONS][MODE_STR_LEN];
static void _delay(void)
{
if (IS_USED(MODULE_XTIMER)) {
xtimer_usleep(DELAY_US);
}
else {
/*
* As fallback for freshly ported boards with no timer drivers written
* yet, we just use the CPU to delay execution and assume that roughly
* 20 CPU cycles are spend per loop iteration.
*
* Note that the volatile qualifier disables compiler optimizations for
* all accesses to the counter variable. Without volatile, modern
* compilers would detect that the loop is only wasting CPU cycles and
* optimize it out - but here the wasting of CPU cycles is desired.
*/
for (volatile uint32_t i = 0; i < CLOCK_CORECLOCK / 20; i++) { }
}
}
static void _get_mode(const uart_data_bits_t data_bits, static void _get_mode(const uart_data_bits_t data_bits,
const uart_parity_t parity, const uart_stop_bits_t stop_bits, char* mode_str) { const uart_parity_t parity, const uart_stop_bits_t stop_bits, char* mode_str) {
@ -153,7 +174,7 @@ int main(void)
if (status == UART_OK) { if (status == UART_OK) {
results[ridx] = true; results[ridx] = true;
printf("%s\n", mode_strings[ridx]); printf("%s\n", mode_strings[ridx]);
xtimer_usleep(DELAY_US); _delay();
} }
else { else {
results[ridx] = false; results[ridx] = false;