riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

shell/sc_gnrc_netif: use fmt_is_number()

Browse Source
This commit is contained in:
Hauke Petersen 2019-12-05 14:13:46 +01:00
parent fd34b5cfd8
commit cea260bb4f
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/shell/commands/sc_gnrc_netif.c
View File

@ -78,17 +78,6 @@ static const struct {
}; };
/* utility functions */ /* utility functions */
static bool _is_number(char *str)
{
for (; *str; str++) {
if (*str < '0' || *str > '9') {
return false;
}
}
return true;
}
static void _print_iface_name(netif_t *iface) static void _print_iface_name(netif_t *iface)
{ {
char name[NETIF_NAMELENMAX]; char name[NETIF_NAMELENMAX];
@ -684,7 +673,7 @@ static int _netif_set_u32(netif_t *iface, netopt_t opt, uint32_t context,
unsigned long int res; unsigned long int res;
bool hex = false; bool hex = false;
if (_is_number(u32_str)) { if (fmt_is_number(u32_str)) {
if ((res = strtoul(u32_str, NULL, 10)) == ULONG_MAX) { if ((res = strtoul(u32_str, NULL, 10)) == ULONG_MAX) {
puts("error: unable to parse value.\n" puts("error: unable to parse value.\n"
"Must be a 32-bit unsigned integer (dec or hex)\n"); "Must be a 32-bit unsigned integer (dec or hex)\n");
@ -796,7 +785,7 @@ static int _netif_set_u16(netif_t *iface, netopt_t opt, uint16_t context,
unsigned long int res; unsigned long int res;
bool hex = false; bool hex = false;
if (_is_number(u16_str)) { if (fmt_is_number(u16_str)) {
if ((res = strtoul(u16_str, NULL, 10)) == ULONG_MAX) { if ((res = strtoul(u16_str, NULL, 10)) == ULONG_MAX) {
puts("error: unable to parse value.\n" puts("error: unable to parse value.\n"
"Must be a 16-bit unsigned integer (dec or hex)\n"); "Must be a 16-bit unsigned integer (dec or hex)\n");