riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "drivers/hd44780: add short delay after each character"

Browse Source 
This reverts commit cf01c743a89e17d78037fcc77f32b8daa859845e.

Adding an unexplained delay seemed wrong in the first place, but it fixed
the display on the MCB2388.

Turns out the display was erroneously operating in 8-bit mode due to the
uninitialized flag register.
Why the delay helped here I don't know.

But with #12634 fixing this, this hack is not needed anymore.
This commit is contained in:
Benjamin Valentin 2019-11-07 22:40:01 +01:00
parent 66d5e4d05f
commit d213bbc6f5
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hd44780/hd44780.c
View File

@ -83,8 +83,6 @@ static void _send(const hd44780_t *dev, uint8_t value, hd44780_state_t state)
_write_bits(dev, 4, value>>4);
_write_bits(dev, 4, value);
}
xtimer_usleep(HD44780_PULSE_WAIT_SHORT);
}
static void _write_bits(const hd44780_t *dev, uint8_t bits, uint8_t value)