riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cpu/esp8266: fix of set func in periph/pwm

Browse Source 
In the `pwm_set` function, the switch-on and switch-off times for PWM channels were only determined for the following phase, but not for the current phase. This could result in a missing duty cycle when calling the function `pwm_set` if the switch-on time of the current phase was not yet reached or to an extended duty cycle if the switch-off time of the current phase had not yet been reached.
This commit is contained in:
Gunar Schorcht 2019-02-10 16:38:49 +01:00 committed by Schorcht
parent 1f9e1857f7
commit d3e0b78f7c
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
cpu/esp8266/periph/pwm.c
View File

@ -183,23 +183,35 @@ void pwm_set(pwm_t pwm, uint8_t channel, uint16_t value)
CHECK_PARAM (value <= _pwm_dev.res); CHECK_PARAM (value <= _pwm_dev.res);
uint32_t state = irq_disable(); uint32_t state = irq_disable();
uint32_t phase = _pwm_dev.cycles - _pwm_dev.cycles % _pwm_dev.res + _pwm_dev.res; uint32_t phase = _pwm_dev.cycles - _pwm_dev.cycles % _pwm_dev.res;
uint32_t next_on = phase;
uint32_t next_off;
switch (_pwm_dev.mode) { switch (_pwm_dev.mode) {
case PWM_LEFT: case PWM_LEFT:
_pwm_dev.chn[channel].next_on = phase; next_on = phase;
break; break;
case PWM_RIGHT: case PWM_RIGHT:
_pwm_dev.chn[channel].next_on = phase + _pwm_dev.res - value; next_on = phase + _pwm_dev.res - value;
break; break;
case PWM_CENTER: case PWM_CENTER:
_pwm_dev.chn[channel].next_on = phase + (_pwm_dev.res - value) / 2; next_on = phase + (_pwm_dev.res - value) / 2;
break; break;
} }
_pwm_dev.chn[channel].next_off = _pwm_dev.chn[channel].next_on + value; next_off = next_on + value;
if (_pwm_dev.cycles >= next_on) {
next_on += _pwm_dev.res;
}
if (_pwm_dev.cycles >= next_off) {
next_off += _pwm_dev.res;
}
_pwm_dev.chn[channel].next_on = next_on;
_pwm_dev.chn[channel].next_off = next_off;
_pwm_dev.chn[channel].duty = value; _pwm_dev.chn[channel].duty = value;
irq_restore(state); irq_restore(state);