From f1079cbe9fa91e0c11fad756b985388ced6dc032 Mon Sep 17 00:00:00 2001 From: Francisco Molina Date: Wed, 20 May 2020 16:25:06 +0200 Subject: [PATCH 1/2] Makefile.include: don't warn about BOARDSDIR usage in sub-make --- Makefile.include | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile.include b/Makefile.include index d555684427..c744b5d358 100644 --- a/Makefile.include +++ b/Makefile.include @@ -99,8 +99,11 @@ endif ifneq (,$(BOARDSDIR)) # Only warn users, not the CI. ifneq ($(RIOT_CI_BUILD),1) - $(warning Using BOARDSDIR is deprecated use EXTERNAL_BOARD_DIRS instead) - $(info EXTERNAL_BOARD_DIRS can contain multiple folders separated by space) + # Do not warn when set from sub-make + ifeq ($(MAKELEVEL),0) + $(warning Using BOARDSDIR is deprecated use EXTERNAL_BOARD_DIRS instead) + $(info EXTERNAL_BOARD_DIRS can contain multiple folders separated by space) + endif endif EXTERNAL_BOARD_DIRS += $(BOARDSDIR) endif From 1bd74ee81f59c2ed170dc77bb1c04987540fbb00 Mon Sep 17 00:00:00 2001 From: Francisco Molina Date: Wed, 20 May 2020 16:26:31 +0200 Subject: [PATCH 2/2] Makefile.include: remove useless assignment of none to BOARD --- Makefile.include | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Makefile.include b/Makefile.include index c744b5d358..8dd0ae1584 100644 --- a/Makefile.include +++ b/Makefile.include @@ -186,10 +186,6 @@ GLOBAL_GOALS += buildtest \ # ifneq (, $(filter $(GLOBAL_GOALS), $(MAKECMDGOALS))) - BOARD=none -endif - -ifeq (none,$(BOARD)) include $(RIOTMAKE)/info-global.inc.mk include $(RIOTMAKE)/buildtests.inc.mk else @@ -950,7 +946,7 @@ ifneq ($(_BASELIBS_VALUE_BEFORE_USAGE),$(BASELIBS)) $(error BASELIBS value changed) endif -endif # BOARD=none +endif # include RIOT_MAKEFILES_GLOBAL_POST configuration files # allows setting user specific system wide configuration parsed after the body