From e8674fd6dd866e171029fc5a1a5747230e3a92a6 Mon Sep 17 00:00:00 2001 From: MrKevinWeiss Date: Tue, 22 Oct 2019 14:13:45 +0200 Subject: [PATCH] MAINTAINING: Clarify guidelines Push for helping contributors and providing snippits. --- MAINTAINING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MAINTAINING.md b/MAINTAINING.md index 52d1dd9390..e69e60e521 100644 --- a/MAINTAINING.md +++ b/MAINTAINING.md @@ -117,6 +117,11 @@ complete that no input from the original developer or maintainer is required. - Be friendly. Respect the original author, bearing in mind that their coding style or their design may be just as valid as the way you would have done it. And of course, always follow the [Code of Conduct]. +- If a contributor has opened a PR, the reviewer should attempt to + help the author of the contribution to get it to its best shape and + according to the RIOT Standard™. If there is disagreement, it’s important + to understand the reasons behind and always give technical arguments, + pros and cons or snippets. ### Organisation of reviewing between maintainers