Merge pull request #14511 from aabadie/pr/ci/build_system_check_makefile_features

ci/build_system_check: improve check for features only provided in Makefile.features
This commit is contained in:
Francisco 2020-07-20 15:28:15 +02:00 committed by GitHub
commit e8a8d12d96
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -66,14 +66,14 @@ check_providing_features_only_makefile_features() {
local patterns=()
local pathspec=()
patterns+=(-e 'FEATURES_PROVIDED *+= *')
patterns+=(-e '^[ ]*FEATURES_PROVIDED *+= *')
pathspec+=("boards/*Makefile*" "cpu/*Makefile*")
pathspec+=("*Makefile\.*")
pathspec+=(":!*Makefile.features")
git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}" \
| error_with_message 'Features in cpu and boards should only be provided in Makefile.features files'
| error_with_message 'Features should only be provided in Makefile.features files'
}
# Some variables do not need to be exported and even cause issues when being