riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/gnrc_rpl_srh: fix test assumption

Browse Source 
If the destination address or an address within the source route is
multicast within a RPL source routing header, a receiving node is
supposed to just discard the packets, but not to send an ICMPv6 error
message, as the test assumes at the moment.

Source: https://tools.ietf.org/html/rfc6554#section-4.2
This commit is contained in:
Martine Lenders 2019-10-14 10:29:58 +02:00
parent c94de51e03
commit ee2126a4e2
1 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
tests/gnrc_rpl_srh/tests/01-run.py
View File

@ -13,7 +13,7 @@ import sys
import subprocess import subprocess
import threading import threading
from scapy.all import Ether, IPv6, \ from scapy.all import Ether, IPv6, UDP, \
IPv6ExtHdrHopByHop, IPv6ExtHdrDestOpt, \ IPv6ExtHdrHopByHop, IPv6ExtHdrDestOpt, \
IPv6ExtHdrFragment, IPv6ExtHdrRouting, \ IPv6ExtHdrFragment, IPv6ExtHdrRouting, \
ICMPv6ParamProblem, ICMPv6TimeExceeded, \ ICMPv6ParamProblem, ICMPv6TimeExceeded, \
@ -194,29 +194,37 @@ def test_seg_left_gt_len_addresses(child, iface, hw_dst, ll_dst, ll_src):
def test_multicast_dst(child, iface, hw_dst, ll_dst, ll_src): def test_multicast_dst(child, iface, hw_dst, ll_dst, ll_src):
# sniffing for ICMPv6 parameter problem message # sniffing for ICMPv6 parameter problem message
sniffer.start_sniff(lambda p: p.haslayer(ICMPv6ParamProblem)) sniffer.start_sniff(lambda p: p.haslayer(ICMPv6ParamProblem) or
(p.haslayer(UDP) and (p[IPv6].dst != "ff02::1")))
# send routing header with multicast destination # send routing header with multicast destination
sendp(Ether(dst=hw_dst) / IPv6(dst="ff02::1", src=ll_src) / sendp(Ether(dst=hw_dst) / IPv6(dst="ff02::1", src=ll_src) /
IPv6ExtHdrRouting(type=3, segleft=1, addresses=["abcd::1"]), IPv6ExtHdrRouting(type=3, segleft=1, addresses=["abcd::1"]) /
iface=iface, verbose=0) UDP(dport=2606), iface=iface, verbose=0)
ps = sniffer.wait_for_sniff_results() ps = sniffer.wait_for_sniff_results()
p = [p for p in ps if ICMPv6ParamProblem in p] p = [p for p in ps if (ICMPv6ParamProblem in p) or
assert(len(p) > 0) ((UDP in p) and (p[UDP].dport == 2606) and
p = p[0] (p[IPv6].dst != "ff02::1"))]
assert(p[ICMPv6ParamProblem].code == 0) # erroneous header field encountered # packet should be discarded silently:
assert(p[ICMPv6ParamProblem].ptr == 24) # IPv6 headers destination field # see https://tools.ietf.org/html/rfc6554#section-4.2
assert(len(p) == 0)
pktbuf_empty(child) pktbuf_empty(child)
def test_multicast_addr(child, iface, hw_dst, ll_dst, ll_src): def test_multicast_addr(child, iface, hw_dst, ll_dst, ll_src):
# sniffing for ICMPv6 parameter problem message
sniffer.start_sniff(lambda p: p.haslayer(ICMPv6ParamProblem) or
(p.haslayer(UDP) and (p[IPv6].dst != ll_dst)))
# Send routing header with multicast address in its destinations # Send routing header with multicast address in its destinations
p = srp1(Ether(dst=hw_dst) / IPv6(dst=ll_dst, src=ll_src) / sendp(Ether(dst=hw_dst) / IPv6(dst=ll_dst, src=ll_src) /
IPv6ExtHdrRouting(type=3, segleft=1, addresses=["ff02::1"]), IPv6ExtHdrRouting(type=3, segleft=1, addresses=["abcd::1"]) /
iface=iface, timeout=1, verbose=0) UDP(dport=2606), iface=iface, verbose=0)
assert(p is not None) ps = sniffer.wait_for_sniff_results()
assert(ICMPv6ParamProblem in p) p = [p for p in ps if (ICMPv6ParamProblem in p) or
assert(p[ICMPv6ParamProblem].code == 0) # erroneous header field encountered ((UDP in p) and (p[UDP].dport == 2606) and
assert(p[ICMPv6ParamProblem].ptr == 48) # first address in routing header (p[IPv6].dst != ll_dst))]
# packet should be discarded silently:
# see https://tools.ietf.org/html/rfc6554#section-4.2
assert(len(p) == 0)
pktbuf_empty(child) pktbuf_empty(child)