riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

drivers/bmx280: Fix incorrect endian conversion

Browse Source 
The binary shift operators in C are defined via the change of their values, not
the change of the memory representation of them. When reading a value from
little endian out of buffer `buf`, `((uint16_t)buf[1] << 8) | buf[0]` will
thus work regardless of the byte order of the host system.
This commit is contained in:
Marian Buschsieweke 2019-11-22 20:58:31 +01:00
parent 550bfdbdbf
commit f08df428fa
No known key found for this signature in database
GPG Key ID: 61F64C6599B1539F
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/bmx280/bmx280.c
View File

@ -123,20 +123,12 @@ static int _read_burst(const bmx280_t *dev, uint8_t reg, void *buf, size_t len)
static uint16_t _to_u16_le(const uint8_t *buffer, size_t offset)
{
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
return (((uint16_t)buffer[offset + 1]) << 8) + buffer[offset];
#else
return (((uint16_t)buffer[offset]) << 8) + buffer[offset + 1];
#endif
return (((uint16_t)buffer[offset + 1]) << 8) | buffer[offset];
}
static int16_t _to_i16_le(const uint8_t *buffer, size_t offset)
{
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
return (((int16_t)buffer[offset + 1]) << 8) + buffer[offset];
#else
return (((int16_t)buffer[offset]) << 8) + buffer[offset + 1];
#endif
return (((int16_t)buffer[offset + 1]) << 8) | buffer[offset];
}
/**