From 9e38f5caa3398216358df9e9d3ad152f60e26099 Mon Sep 17 00:00:00 2001 From: Marian Buschsieweke Date: Tue, 11 Feb 2020 19:25:55 +0100 Subject: [PATCH] Makefile.dep: Fix dependency resolution The addition of the `ecc` dependency was done after the recursion is done to catch transient dependencies. This could potentially miss transient deps. This commit moves the affected code before the recursion is triggered. --- Makefile.dep | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.dep b/Makefile.dep index 79c4791acf..18983bde28 100644 --- a/Makefile.dep +++ b/Makefile.dep @@ -1043,13 +1043,13 @@ ifneq (,$(filter periph_%, $(USEMODULE))) USEMODULE += periph_common endif +ifneq (,$(filter ecc_%,$(USEMODULE))) + USEMODULE += ecc +endif + # recursively catch transitive dependencies USEMODULE := $(sort $(USEMODULE)) USEPKG := $(sort $(USEPKG)) ifneq ($(OLD_USEMODULE) $(OLD_USEPKG),$(USEMODULE) $(USEPKG)) include $(RIOTBASE)/Makefile.dep endif - -ifneq (,$(filter ecc_%,$(USEMODULE))) - USEMODULE += ecc -endif