riot-ci/RIOT
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

destiny: segfault due to dereferencing nullpointer

Browse Source 
get_socket(i) returns NULL, when no specific socket is found.
Without an appropriate check for NULL, the current state
of the code leads to a segfault.

destiny: added parens

destiny: continuing the loop makes more sense than returning at first sight of NULL
This commit is contained in:
Cenk Gündoğan 2014-06-03 21:57:55 +02:00
parent e84cdd67b7
commit f41fe7bb04
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/net/transport_layer/destiny/socket.c
View File

@ -1194,6 +1194,10 @@ socket_internal_t *get_waiting_connection_socket(int socket,
for (i = 1; i < MAX_SOCKETS + 1; i++) { for (i = 1; i < MAX_SOCKETS + 1; i++) {
current_socket = get_socket(i); current_socket = get_socket(i);
if (!current_socket) {
continue;
}
/* Connection establishment ACK, Check for 4 touple and state */ /* Connection establishment ACK, Check for 4 touple and state */
if ((ipv6_header != NULL) && (tcp_header != NULL)) { if ((ipv6_header != NULL) && (tcp_header != NULL)) {
if (is_four_touple(current_socket, ipv6_header, tcp_header) && if (is_four_touple(current_socket, ipv6_header, tcp_header) &&