6605 Commits

Author SHA1 Message Date
Martine Lenders
2a1e002d6d
Merge pull request #12627 from miri64/gnrc_sixlowpan_iphc_nhc/enh/frag+iphc-payload_len
gnrc_sixlowpan_iphc_nhc: determine UDP hdr length from RB
2019-11-01 19:47:08 +01:00
Martine S. Lenders
f33111a9c2 gnrc_sixlowpan_iphc: remove duplicate gnrc_netif_hdr_get_netif()
The interface is already fetched in the beginning of the function and
doesn't change during its run, so getting the interface again at this
point is just redundant.
2019-11-01 18:29:44 +01:00
benpicco
865059fc66
Merge pull request #11230 from maribu/xtimer_msg_deps
sys/xtimer: Remove dependency to core_msg
2019-11-01 15:22:10 +01:00
Martine S. Lenders
806f33fce4 gnrc_sixlowpan_iphc_nhc: determine UDP hdr length from RB
When decoding IPHC in a fragmented datagram, relying on the size of the
allocated space for the decoded packet is wrong when fragments are
forwarded and decoded on an intermediate node (for which the reassembly
buffer's space is used): Using the full datagram size for allocation in
this case would be wasteful, so the allocated space is only marginally
larger than the fragment's compressed form.
This in turn results in the wrong UDP payload size being chosen and
even worse being forwarded to the subsequent nodes.

This change uses the (virtual) reassembly buffer's `datagram_size`
instead of relying on the allocated space for the encoded
datagram/fragment.
2019-11-01 13:18:00 +01:00
benpicco
3a87e2d2e6
Merge pull request #12624 from miri64/sock_async/fix/compile-time-errors
sock_async: fix compile-time errors
2019-10-31 21:26:05 +01:00
Marian Buschsieweke
cd1ce6b98d
sys/xtimer: Remove dependency to core_msg
When module `core_msg` is not used, `xtimer` now no longer provides the features
related to messages. This allows using `xtimer` without `core_msg`.
2019-10-31 19:55:50 +01:00
Sebastian Meiling
ca696f827b
Merge pull request #12193 from leandrolanzieri/pr/gcoap/obs
gcoap: Add 'obs' attribute in example and extend documentation
2019-10-31 18:14:23 +01:00
Martine S. Lenders
de47681d03 sock_async: fix compile-time errors 2019-10-31 16:01:49 +01:00
Juergen Fitschen
e152b3e346 sys/riotboot: Fixed flashwrite_slotsize to return size of slot 1 2019-10-31 12:05:35 +01:00
Alexandre Abadie
8b06560c02
sys/net/nanocoap: correctly initialize array 2019-10-30 17:03:06 +01:00
Alexandre Abadie
95da51bd7f
sys/net/nanocoap: fix potential use of uinitialized variable 2019-10-30 17:03:06 +01:00
Alexandre Abadie
5d1480a4b8
sys/net/nanocoap: fail when start data cannot be parsed 2019-10-30 17:03:06 +01:00
Alexandre Abadie
1aa1e2c8cc
sys/net/nanocoap: return ENOENT if parsing option failed
This fixes a potential use of uninitialized len in subsequent function calls.

This was reported by scan-build
2019-10-30 17:03:06 +01:00
Martine Lenders
5b4b12ed07
Merge pull request #11723 from miri64/sock/enh/async2
sock: initial definitions for asynchronous event handling
2019-10-30 16:59:11 +01:00
Martine Lenders
bf5b53392c
Merge pull request #12603 from jia200x/pr/link_up
netopt: redefine NETOPT_LINK_CONNECTED
2019-10-30 15:19:07 +01:00
Martine Lenders
f0b5eb04c1 sock: initial import of asynchronous event definitions 2019-10-30 13:23:31 +01:00
Jose Alamos
f38a786108 sc_gnrc_netif: implement link command 2019-10-30 13:13:06 +01:00
Jose Alamos
6beec0a4f6 netopt: update doc of NETOPT_LINK 2019-10-30 12:13:36 +01:00
Jose Alamos
43a5fdc870 netopt: rename NETOPT_LINK_CONNECTED 2019-10-30 12:13:36 +01:00
Martine Lenders
ea4b78654f
Merge pull request #12285 from JulianHolzwarth/pr/posix/pthread/pthread_reaper_fix
sys/posix/pthread/pthread.c: fix pthread reaper
2019-10-29 18:56:36 +01:00
Martine S. Lenders
dba2f9e5ea gnrc_sixlowpan_frag: remove code duplication on fragment creation 2019-10-29 15:34:24 +01:00
Martine S. Lenders
d5e21f35c3 gnrc_sixlowpan_frag: copy netif header directly 2019-10-29 15:34:24 +01:00
benpicco
acaaee910e
Merge pull request #12536 from bergzand/pr/usbus/cdcacm_activate_on_dte_present
cdcacm: Activate data out endpoint on DTE present signal
2019-10-29 13:03:39 +01:00
Martine Lenders
526c963f43
Merge pull request #12594 from jia200x/pr/deprecate/gnrc_nettest
gnrc_nettest: add deprecation note
2019-10-29 10:59:14 +01:00
Jose Alamos
5b179b6d80 gnrc_nettest: add deprecation note
This module was intended to be a test framework for GNRC but it never
really got used. It was not maintained for 3 years. It will be removed
after 2020.07 release at the latest.
2019-10-29 10:41:45 +01:00
Martine Lenders
05d338169d
Merge pull request #12367 from brummer-simon/gnrc_tcp-fix_recv_conn_closed
gnrc_tcp: return immediatly on gnrc_tcp_recv if a connection is closing
2019-10-29 09:54:43 +01:00
Koen Zandberg
1d7032a257
cdcacm: Activate data out endpoint on DTE present signal 2019-10-29 08:45:31 +01:00
Koen Zandberg
727263ce73
Merge pull request #12533 from bergzand/pr/usbus/cdcecm_ready_on_iface
cdcecm: only activate OUT endpoint after interface selection
2019-10-29 07:55:35 +01:00
benpicco
456982f595
Merge pull request #12595 from aabadie/pr/net/sock_util_scan_build
sys/net/sock_util: fix dead initialization warning
2019-10-28 17:24:50 +01:00
Alexandre Abadie
2b0b591c85
sys/net/sock_util: fix dead initialization warning
This was reported by LLVM scan build. The value assigned at initialization is never used, so could be removed
2019-10-28 16:35:18 +01:00
Alexandre Abadie
a9399810d5
sys/net/uhcp: remove unused returned value in uhcp_client 2019-10-28 15:14:40 +01:00
benpicco
422d6d5f1a
Merge pull request #12582 from aabadie/pr/sys/sha_dead_assignment
sys/sha3: fix dead assignment of blockSize in Keccak_update
2019-10-27 13:05:16 +01:00
Alexandre Abadie
aaadaccc3f
sys/net/nanocoap: fix dead assignment in nanocoap server 2019-10-27 10:49:41 +01:00
Alexandre Abadie
74919d0646
sys/sha3: fix dead assignment of blockSize in Keccak_update 2019-10-27 10:44:54 +01:00
Gunar Schorcht
e38d3e24ec
Merge pull request #12548 from maribu/c11_atomcis_cpp_compat
sys: Basic C++ compatibility with C11 atomcis
2019-10-25 11:48:58 +02:00
d8d7f77b7d
Merge pull request #12567 from aabadie/pr/sys/riotboot_remove_unused_variable
sys/flashwrite: remove useless line
2019-10-25 10:26:07 +02:00
Marian Buschsieweke
cd8562e8c0
sys: Added basic C++ compat for C11 atomics
Added a header to allow defining C interfaces using the default C11 atomic
types. Those types are however fully opaque and inaccessible from C++, as C11
atomics are completely incompatible with C++.
2019-10-24 23:08:35 +02:00
benpicco
afecb9aa7a
Merge pull request #12562 from kaspar030/pr/suit_v4_nanocbor
sys/suit/v4: switch to nanocbor
2019-10-24 19:15:25 +02:00
Marian Buschsieweke
1c624e457c
Merge pull request #10592 from gschorcht/sys_arduino_ext
sys/arduino: Added Wire (I2C) interface
2019-10-24 18:28:11 +02:00
Francisco
0364c39694
Merge pull request #12408 from miri64/gnrc_netif/fix/src-addr-selection
gnrc_netif: only use prefix matching as tie-breaker in source selection
2019-10-24 17:14:17 +02:00
4ccb4e5995 sys/suit/v4: switch to nanocbor
Co-authored-by: Francisco <femolina@uc.cl>
2019-10-24 16:48:00 +02:00
Martine S. Lenders
e9d75f5655 gnrc_netif: remove filter parameter from _match_to_idx()
`_match_to_idx()` was removed from source address selection (which was
the only one setting the filter parameter to a non-NULL value), so it
is the parameter is not needed anymore.
2019-10-24 16:04:41 +02:00
Martine S. Lenders
e787f6b60d gnrc_netif: only use prefix matching as tie-breaker in source selection
When source address selection is done, both RFC and comments in the code
state, that a longest prefix match should *only* be used as a
tie-breaker between more than one viable candidate. If there is only one
address, there is

a) no need for a tie-breaker
b) in the case of either the destination address or the single remaining
   address being ULAs ([which are considered to be of global scope]
   [RFC4193]) possibly not matching, as `fd00::/7` and e.g. `2001::/8`
   do not have a common prefix.

(b) in fact causes the match function to return -1, causing the source
address selection to return -1, causing the outer function to return the
first address it found (which most often is the link-local address),
causing e.g. a ping to an ULA to fail, even is there is a global
address.

[RFC4193]: https://tools.ietf.org/html/rfc4193
2019-10-24 16:04:41 +02:00
Cenk Gündoğan
e0ab8776f3
Merge pull request #12547 from miri64/gnrc_netif/enh/warn-no-ARSM
gnrc_netif: warn when not joining solicited-nodes from non-6LN netif
2019-10-24 13:46:38 +02:00
Martine Lenders
e990b26d5b
Merge pull request #12560 from miri64/gnrc_sixlowpan/cleanup/rb-remainders
gnrc_sixlowpan: move remaining reassembly buffer components to gnrc_sixlowpan_frag_rb
2019-10-24 13:38:55 +02:00
Vincent Dupont
3fb3b62ea2
Merge pull request #12507 from gschorcht/core/static_assert
core/assert: allow multiple static_asserts within a function
2019-10-24 13:38:00 +02:00
Martine Lenders
796d6a3167 gnrc_sixlowpan: move garbage collect msg type to reassembly buffer 2019-10-24 12:41:29 +02:00
Martine Lenders
750fd30bb4 gnrc_sixlowpan_config: fix module doc for reassembly buffer config 2019-10-24 12:41:29 +02:00
Martine Lenders
0838199c36
Merge pull request #12555 from miri64/gnrc_pktbuf_static/enh/unify-ptr-stats
gnrc_pktbuf_static: unify NULL pointer output for stats
2019-10-24 09:09:19 +02:00
Gunar Schorcht
3fc2c60f20 sys/arduino: add Wire (I2C) library implementation 2019-10-24 08:33:49 +02:00